Skip to content

fix auto backward bug - #63113

Merged
winter-wang merged 2 commits into
PaddlePaddle:developfrom
winter-wang:ir_develop
Apr 1, 2024
Merged

winter-wang merged 2 commits into
PaddlePaddle:developfrom
winter-wang:ir_develop

Conversation

@winter-wang

@winter-wang winter-wang commented Mar 29, 2024 •

Copy link
Copy Markdown
Collaborator

PR Category

Others

PR Types

Bug fixes

Description

  • fix the bug in pir auto backward.
    while the stop_gradient of all inputs is true, we should skip calling the vjp interface.

@paddle-bot

paddle-bot Bot commented Mar 29, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot

paddle-bot Bot commented Mar 29, 2024

Copy link
Copy Markdown

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

zhiqiu
zhiqiu previously approved these changes Mar 29, 2024

@zhiqiu zhiqiu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang
winter-wang force-pushed the ir_develop branch 2 times, most recently from 5914b93 to fde3de2 Compare March 31, 2024 19:28
]:
continue

if all_input_stop_gradient_true(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一下注释吧

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,下个pr补充相关说明。

@winter-wang
winter-wang merged commit c2bf8d4 into PaddlePaddle:develop Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants