Repository navigation
[PIR] Adaptation of TestNoBackwardAPIStatic.test_unique* - #62794
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Mar 17, 2024
| self.assertEqual(inverse, 0) | ||
| self.assertEqual(counts, 1) | ||
| self.assertEqual(res[0].shape, (1,)) | ||
| res = self.exe.run(prog, fetch_list=[x, y, inverse, counts]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| res = self.exe.run(prog, fetch_list=[x, y, inverse, counts]) | |
| x_res, y_res, inverse_res, counts_res = self.exe.run(prog, fetch_list=[x, y, inverse, counts]) |
这样一目了然，不然下面取下标还得看 0、1、2、3 分别是啥
| self.assertEqual(counts, 1) | ||
| self.assertEqual(res[0].shape, (1,)) | ||
| res = self.exe.run(prog, fetch_list=[x, y, inverse, counts]) | ||
| self.assertEqual(res[0], res[1]) |
Collaborator
There was a problem hiding this comment.
合理，原来代码就是个隐藏的 bug，Variable == Variable 返回 Variable，bool(Variable) 永远为 True
Comment on lines
+500
to
+501
| self.assertEqual(res[2], 0) | ||
| self.assertEqual(res[3], 1) |
| self.assertEqual(inverse, 0) | ||
| self.assertEqual(counts, 1) | ||
| self.assertEqual(res[0].shape, (1,)) | ||
| res = self.exe.run(prog, fetch_list=[x, y, index, inverse, counts]) |
SigureMo
approved these changes
Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
适配
test/legacy_test/test_zero_dim_no_backward_api.py下的TestNoBackwardAPIStatic.test_unique_consecutive和TestNoBackwardAPIStatic.test_unique，改为测试执行后的结果我们在这里不能直接使用
Value进行比较，一个是unique_consecutive，一个是uniform相关链接:
test_zero_dim_*.py- step: 2 #62652bool(Value)always throw error #60902