Skip to content

Fix Paddle-TRT UT fails - #61377

Merged
Wangzheee merged 1 commit into
PaddlePaddle:developfrom
leo0519:fix-trt-ut
Feb 3, 2024
Merged

Fix Paddle-TRT UT fails#61377
Wangzheee merged 1 commit into
PaddlePaddle:developfrom
leo0519:fix-trt-ut

Conversation

@leo0519

@leo0519 leo0519 commented Jan 31, 2024

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Description

Modifications

  • No data type conversion for input of non-floating precision at default if self.input_type is set
  • Align the constraint in UTs with Paddle-TRT op teller

Fix the following UTs:

  • test_trt_convert_bitwise_or
  • test_trt_convert_bitwise_and
  • test_trt_convert_assign
  • test_trt_convert_scatter
  • test_trt_convert_cast

@leo0519 leo0519 added the NVIDIA label Jan 31, 2024
@leo0519
leo0519 requested review from Wangzheee and ming1753 January 31, 2024 01:50
ming1753
ming1753 approved these changes Jan 31, 2024
View reviewed changes

@ming1753 ming1753 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeng1220 jeng1220 mentioned this pull request Feb 1, 2024
Closed
Wangzheee
Wangzheee approved these changes Feb 3, 2024
View reviewed changes

@Wangzheee Wangzheee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wangzheee
Wangzheee merged commit 1291468 into PaddlePaddle:develop Feb 3, 2024
@leo0519 leo0519 mentioned this pull request Feb 5, 2024
Merged
@leo0519
leo0519 deleted the fix-trt-ut branch July 7, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianshuo78520a tianshuo78520a Awaiting requested review from tianshuo78520a
2 more reviewers
@Wangzheee Wangzheee Wangzheee approved these changes
@ming1753 ming1753 ming1753 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@heavengate heavengate

Labels

NVIDIA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leo0519 @Wangzheee @ming1753 @heavengate