Repository navigation
[PIR] A-12 Adapt concat test_errors - #61036
Merged
0x45f merged 14 commits intoFeb 21, 2024
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
enkilee
changed the title
Collaborator
|
create_lod_tensor这个接口在pir下没有适配，后面应该也不会适配了，所以本PR里的涉及到的两个test_error单测不需要适配，先恢复原样吧。可以尝试加一个新的测试error的case，老静态图和PIR下都可以跑，然后用test_with_pir_api装饰一下~ |
Collaborator
Author
收到，我看合入的示例里面还是create_lod_tensor，我改的试试。 |
0x45f
reviewed
Jan 30, 2024
Collaborator
|
这里应该是PIR CPP端的检查逻辑不够完善，我来修改一下~ |
added 3 commits
February 2, 2024 08:39
… Add-test_with_pir_api-in-error-test-12
… Add-test_with_pir_api-in-error-test-12
0x45f
approved these changes
Feb 21, 2024
Aurelius84
approved these changes
Feb 21, 2024
YuanRisheng
reviewed
Feb 21, 2024
| if (vector_value.size() <= 1) { | ||
| return true; | ||
| } | ||
| auto dtype = GetValueDataType(vector_value[0]); |
Collaborator
There was a problem hiding this comment.
这个函数是检查vector中的value的dtype是否全都相同，所以取了第0个元素进行比较
YuanRisheng
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
A-12 concat