Repository navigation
[Fix] refactor copysign - #60968
Merged
Merged
[Fix] refactor copysign#60968
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
18 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Description
问题复现:
docker镜像:
编译脚本
修改前报错信息:

原cuda实现编译后的.o较大:

可能是原来的实现在正向反向时都实现了一份
copysign_func的模板。现将copysign合并至elementwise系列中,copysign_func的模板以及copysign相关的Functor都迁移至funcs下,供前向和反向复用。elementwise相关编译中间产物:并入copysign前:

并入copysign后:

前向cu.o (+5.2M),反向cu.o(+4.0M),可通过该镜像和cmake选项下的编译