Repository navigation
[Dy2St] Make translator logger lazy format and add error message for builtin type conversion methods - #60836
Merged
SigureMo merged 4 commits intoJan 19, 2024
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
5 tasks done
xiaoguoguo626807
approved these changes
Jan 19, 2024
xiaoguoguo626807
left a comment
Contributor
There was a problem hiding this comment.
LGTM for backward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
logger 里直接 format 的话,如果用户自定义了一个 callable object,而且
__str__写了动转静运行不了的代码,则会报错,比如为 Variable、Value 添加 float、
bool、int 等 builtin 类型转换方法,均为直接报错,引导替换写法(bool 由于现有框架里有大量错误用法,因此单独提一个 PR,以不阻塞本 PR 推进)并为 SOT 添加了遗漏的应当 breakgraph 的方法 float
PCard-66972