Repository navigation
【PIR API adaptor No.171】Migrate paddle.vision.ops.PSRoIPool into pir - #60353
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
MarioLulab
reviewed
Dec 27, 2023
MarioLulab
left a comment
MarioLulab
left a comment
Collaborator
There was a problem hiding this comment.
TestPSROIPoolStaticAPI 单测的输入 self.boxes_placeholder 仍然有 lod_level 。但目前 pir 模式暂不支持 lod 输入，可以考虑在 test/legacy_test/test_psroi_pool_op.py 文件下新增一个 pir 单测
MarioLulab
reviewed
Dec 28, 2023
0x45f
reviewed
Jan 5, 2024
|
|
||
| class TestPSROIPoolStaticAPI_NOLOD(unittest.TestCase): | ||
| def setUp(self): | ||
| paddle.enable_static() |
Collaborator
There was a problem hiding this comment.
在测试case里用了IrGuard是不是不需要手动切到静态图了？在setUp里切到静态图可能会影响后续单测运行时的模式，这里删掉 paddle.enable_static() 试试呢
|
Sorry to inform you that a0f04ee's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
MarioLulab
reviewed
Jan 9, 2024
MarioLulab
left a comment
MarioLulab
left a comment
Collaborator
There was a problem hiding this comment.
o 师傅最近还有时间来推进这个 pr 吗~
Collaborator
Author
|
YuanRisheng
approved these changes
Jan 16, 2024
0x45f
approved these changes
Jan 16, 2024
18 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
link #58067
PIR API 推全升级
将 paddle.vision.ops.PSRoIPool 迁移升级至 pir，并更新单测
单测覆盖率: 1/8
继承自optest的单侧未开启，暂不支持 lod操作