Skip to content

[WIP] Migrate paddle.distribution.Normal into pir - #59922

Closed
MarioLulab wants to merge 1 commit into
PaddlePaddle:developfrom
MarioLulab:luqi/wip_normal
Closed

MarioLulab wants to merge 1 commit into
PaddlePaddle:developfrom
MarioLulab:luqi/wip_normal

Conversation

@MarioLulab

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Description

用来讨论:#59910

@paddle-bot

paddle-bot Bot commented Dec 12, 2023

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

self.run_old_ir_normal_distribution_static(sample_shape)

self.compare_with_numpy(fetch_list)
self.init_static_data(self.batch_size, self.dims, in_pir=True)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接加两个吗,需不需要判断是否在pir模式下捏~

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照我当前的写法,在 test_normal_distribution_static 函数体中,如果没进到 IrGuard 的管理范围内的话,应该都不是 pir 模式,所以没法用 paddle.base.framework.in_pir_mode 进行判断。所以我这里直接加两个了,o师傅也可以按自己的想法来~ 我的仅作参考

@paddle-ci-bot

paddle-ci-bot Bot commented Dec 29, 2023

Copy link
Copy Markdown

Sorry to inform you that cfd91d3's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@MarioLulab MarioLulab closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants