Skip to content

【PIR API adaptor No.257、265】Migrate gcd,lcm into pir - #59600

Merged
0x45f merged 7 commits into
PaddlePaddle:developfrom
enkilee:pir-api-265-257
Dec 11, 2023
Merged

0x45f merged 7 commits into
PaddlePaddle:developfrom
enkilee:pir-api-265-257

Conversation

@enkilee

@enkilee enkilee commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

APIs

Description

PIR API 推全升级 * #58067

No.257 paddle.Tensor.gcd
No.265 paddle.Tensor.lcm

因为lcm要使用gcd,故放一起。

将 paddle.Tensor.gcd 迁移升级至 pir,并更新单测 单测覆盖率:5/5
将 paddle.Tensor.lcm 迁移升级至 pir,并更新单测 单测覆盖率:5/5

@paddle-bot paddle-bot Bot added the contributor External developers label Dec 1, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 4, 2023
@enkilee

enkilee commented Dec 6, 2023 •

Copy link
Copy Markdown
Collaborator Author

@MarioLulab 改的这2个单测一直超时,不知为什么。

@MarioLulab

Copy link
Copy Markdown
Collaborator

@MarioLulab 改的这2个单测一直超时,不知为什么。

收到,正在本地复现该问题,有进展了我及时在这个 pr 下面 comment ~

Comment thread python/paddle/tensor/math.py Resolved

@MarioLulab MarioLulab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread test/legacy_test/test_gcd.py Resolved
Comment thread test/legacy_test/test_lcm.py Resolved
@0x45f
0x45f merged commit 257f5d3 into PaddlePaddle:develop Dec 11, 2023
@enkilee
enkilee deleted the pir-api-265-257 branch December 14, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants