Skip to content

【Hackathon 5th No.11】add gammaincc and gammainc API - #59357

Merged
luotao1 merged 29 commits into
PaddlePaddle:developfrom
GreatV:add_igamma_igammac
Jan 24, 2024
Merged

【Hackathon 5th No.11】add gammaincc and gammainc API#59357
luotao1 merged 29 commits into
PaddlePaddle:developfrom
GreatV:add_igamma_igammac

Conversation

@GreatV

@GreatV GreatV commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

PR types

New features

PR changes

APIs

Description

@paddle-bot

paddle-bot Bot commented Nov 24, 2023

Copy link
Copy Markdown

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Nov 24, 2023
@luotao1 luotao1 mentioned this pull request Nov 24, 2023
Closed
@luotao1

luotao1 commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

请补充单测通过覆盖率流水线

zxcd
zxcd reviewed Dec 19, 2023
View reviewed changes
Comment thread paddle/phi/kernels/cpu/igamma_grad_kernel.cc Resolved
@GreatV GreatV mentioned this pull request Dec 19, 2023
Merged
@zxcd

zxcd commented Dec 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

igamma 和 igammac 的计算比较相似，是否能够实现其中一个(例如 igamma )，然后另一个用 1-igamma 的计算方式实现？

zxcd
zxcd reviewed Dec 20, 2023
View reviewed changes
Comment thread test/legacy_test/test_igammac_op.py Resolved
Comment thread test/legacy_test/test_igammac_op.py Resolved
@GreatV

GreatV commented Dec 20, 2023

Copy link
Copy Markdown
Collaborator Author

igamma 和 igammac 的计算比较相似，是否能够实现其中一个(例如 igamma )，然后另一个用 1-igamma 的计算方式实现？

应该是可以的，我改一下。

@GreatV
GreatV requested a review from zxcd December 21, 2023 01:59
zxcd
zxcd reviewed Jan 4, 2024
View reviewed changes
Comment thread test/legacy_test/test_igamma_op.py Resolved
zxcd
zxcd approved these changes Jan 8, 2024
View reviewed changes

@zxcd zxcd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeff41404
jeff41404 reviewed Jan 8, 2024
View reviewed changes
Comment thread paddle/phi/kernels/impl/igamma_kernel_impl.h Resolved
jeff41404
jeff41404 reviewed Jan 8, 2024
View reviewed changes
Comment thread python/paddle/tensor/math.py Resolved
jeff41404
jeff41404 reviewed Jan 9, 2024
View reviewed changes
Comment thread paddle/phi/api/yaml/ops.yaml Resolved
jeff41404
jeff41404 reviewed Jan 9, 2024
View reviewed changes
Comment thread python/paddle/tensor/math.py Resolved
jeff41404
jeff41404 reviewed Jan 9, 2024
View reviewed changes
Comment thread python/paddle/tensor/math.py Resolved
sunzhongkai588
sunzhongkai588 previously approved these changes Jan 9, 2024
View reviewed changes

@sunzhongkai588 sunzhongkai588 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@luotao1

luotao1 commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

@GreatV 可以提交中文文档

@jeff41404

jeff41404 commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

Pay attention to modify the title and description of PR, use gammaincc instead of igamma

@GreatV GreatV changed the title 【Hackathon 5th No.11】add igamma and igammac API 【Hackathon 5th No.11】add gammaincc and gammainc API Jan 11, 2024
@paddle-ci-bot

paddle-ci-bot Bot commented Jan 17, 2024

Copy link
Copy Markdown

Sorry to inform you that d7c1b59's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

jeff41404
jeff41404 approved these changes Jan 24, 2024
View reviewed changes

@jeff41404 jeff41404 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
luotao1 merged commit ca48326 into PaddlePaddle:develop Jan 24, 2024
@GreatV GreatV mentioned this pull request Jan 24, 2024
Merged
@XieYunshen

XieYunshen commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

单测 : test_gammaincc_op, PR: 61049,CI : PR-CI-Mac-Python3,url : https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/9982634
单测 : test_gammaincc_op, PR: 61096,CI : PR-CI-Mac-Python3,url : https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/9982843
单测 : test_gammaincc_op, PR: 61010,CI : PR-CI-Windows-OPENBLAS,url : https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/9982926

@GreatV GreatV mentioned this pull request Jan 24, 2024
Merged
@SigureMo

SigureMo commented Jan 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@GreatV 可参考 #60902 描述和相关 case 的修复方式，需要考虑静态图的情况

@GreatV

GreatV commented Jan 24, 2024

Copy link
Copy Markdown
Collaborator Author

@SigureMo 好的，我看下。

eee4017 pushed a commit to eee4017/Paddle that referenced this pull request Jan 30, 2024
@GreatV @eee4017
【Hackathon 5th No.11】add gammaincc and gammainc API (PaddlePaddle…
bad3c29 
…#59357)

* 【Hackathon 5th No.11】add igamma and igammac API

* fix bug

* Merge branch 'develop' into add_igamma_igammac

* fix codestyle

* fix bug

* update ut

* fix bug

* fix bug

* add test inplace

* fix bug

* fix bug

* remove unused comment

* remove some c++ impl

* update code

* fix bug

* fix bug

* update

* remove some paddle.enable_static()

* remove eigen impl

* fix test_inplace

* rename op

* igamma(a, x) -> gammaincc(x, y)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes
@sunzhongkai588 sunzhongkai588 sunzhongkai588 left review comments
+1 more reviewer
@zxcd zxcd zxcd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@luotao1 luotao1

@zxcd zxcd

Labels

contributor External developers PaddlePaddle Hackathon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GreatV @luotao1 @zxcd @jeff41404 @XieYunshen @SigureMo @sunzhongkai588