Skip to content

【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir - #58911

Merged
0x45f merged 24 commits into
PaddlePaddle:developfrom
enkilee:pir-api-75
Dec 8, 2023
Merged

【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir#58911
0x45f merged 24 commits into
PaddlePaddle:developfrom
enkilee:pir-api-75

Conversation

@enkilee

@enkilee enkilee commented Nov 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将 paddle.incubate.nn.functional.fused_rotary_position_embedding 迁移升级至 pir，并更新单测 单测覆盖率：1/1

@enkilee enkilee changed the title 【PIR API adaptor No.83-86】Migrate FusedLinear，fused_linear_activation，fused_matmul_bias，FusedMultiTransformer，fused_rotary_position_embedding into pir 【PIR API adaptor No.83-87】Migrate FusedLinear，fused_linear_activation，fused_matmul_bias，FusedMultiTransformer，fused_rotary_position_embedding into pir Nov 10, 2023
@paddle-bot

paddle-bot Bot commented Nov 10, 2023

Copy link
Copy Markdown

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Nov 10, 2023
@luotao1 luotao1 mentioned this pull request Nov 13, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 13, 2023
MarioLulab
MarioLulab reviewed Nov 13, 2023
View reviewed changes

@MarioLulab MarioLulab left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FusedLinear: 在 test/legacy_test/test_fused_matmul_bias.py 里有相关静态图单测
FusedMultiTransformer ：在 test/legacy_test/test_fused_multi_transformer_op.py 有相关静态图单测
麻烦为这些单测打开 pir 测试的开关吧~

Comment thread python/paddle/incubate/nn/functional/fused_matmul_bias.py Resolved
Comment thread python/paddle/incubate/nn/functional/fused_matmul_bias.py Resolved
Comment thread python/paddle/incubate/nn/functional/fused_transformer.py Resolved
@0x45f

0x45f commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

fused_gemm_epilogue OP目前还没有迁移到phi下，可以先跳过这个api，适配其他的api并打开对应单测

MarioLulab
MarioLulab reviewed Nov 28, 2023
View reviewed changes

@MarioLulab MarioLulab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然 fused_gemm_epilogue 还无法适配 pir，那么麻烦请修改一下 pr 标题和 pr 描述吧，把 paddle.incubate.nn.FusedLinear, paddle.incubate.nn.functional.fused_linear_activation, paddle.incubate.nn.functional.fused_matmul_bias 删除

Comment thread test/legacy_test/test_fused_multi_transformer_op.py Resolved
@enkilee enkilee changed the title 【PIR API adaptor No.83-87】Migrate FusedLinear，fused_linear_activation，fused_matmul_bias，FusedMultiTransformer，fused_rotary_position_embedding into pir 【PIR API adaptor No.83-87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir Nov 28, 2023
@MarioLulab

MarioLulab commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

PR 标题的前缀题号应该是 ：【PIR API adaptor No.86、87】
麻烦修改一下吧

@enkilee enkilee changed the title 【PIR API adaptor No.83-87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir 【PIR API adaptor No.86，87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir Nov 30, 2023
@enkilee enkilee changed the title 【PIR API adaptor No.86，87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir 【PIR API adaptor No.86、87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir Nov 30, 2023
@0x45f

0x45f commented Nov 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

TestFusedMultiTransformerOp.test_fused_multi_transformer_op测试为什么没有打开pir的测试呀？另外更新下pr描述吧~

@MarioLulab

MarioLulab commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

TestFusedMultiTransformerOp.test_fused_multi_transformer_op测试为什么没有打开pir的测试呀？另外更新下pr描述吧~

因为这个单测是动态图单测，所以没有打开 pir 测试

@0x45f

0x45f commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

本地有跑过test/legacy_test/test_fused_multi_transformer_op.py这个单测吗？ci上这个单测被禁了，所以没有这个文件没有被跑到。我看单测中的GetFusedMultiTransformerOutStatic函数在PIR下执行应该还是会有问题，建议在本地跑一下，修复一下相关的问题~

@enkilee

enkilee commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator Author

本地有跑过test/legacy_test/test_fused_multi_transformer_op.py这个单测吗？ci上这个单测被禁了，所以没有这个文件没有被跑到。我看单测中的GetFusedMultiTransformerOutStatic函数在PIR下执行应该还是会有问题，建议在本地跑一下，修复一下相关的问题~

额，本地没环境跑，我看静态是跑在GPU下的。抱歉。

@MarioLulab

MarioLulab commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

本地有跑过test/legacy_test/test_fused_multi_transformer_op.py这个单测吗？ci上这个单测被禁了，所以没有这个文件没有被跑到。我看单测中的GetFusedMultiTransformerOutStatic函数在PIR下执行应该还是会有问题，建议在本地跑一下，修复一下相关的问题~

额，本地没环境跑，我看静态是跑在GPU下的。抱歉。

那我在本地用 GPU 环境运行一下吧~ 有进展了会在这个 pr 下 comment 😄

@MarioLulab

MarioLulab commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

当前 fused_multi_transformer 的 kernel 还没有从 fluid 迁移到 phi 体系下，所以目前 fused_multi_transformer 这个 pir api 的迁移工作可以先搁置。这个 pr 暂时只保留 fused_rotary_position_embedding 的工作吧。麻烦复原一下 fused_multi_transformer 及其单测代码，并修改本 pr 标题 🤝

@enkilee

enkilee commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator Author

当前 fused_multi_transformer 的 kernel 还没有从 fluid 迁移到 phi 体系下，所以目前 fused_multi_transformer 这个 pir api 的迁移工作可以先搁置。这个 pr 暂时只保留 fused_rotary_position_embedding 的工作吧。麻烦复原一下 fused_multi_transformer 及其单测代码，并修改本 pr 标题 🤝

收到，辛苦佬🤝🤝

@enkilee enkilee changed the title 【PIR API adaptor No.86、87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir 【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir Dec 7, 2023
@0x45f
0x45f merged commit c45faed into PaddlePaddle:develop Dec 8, 2023
@enkilee
enkilee deleted the pir-api-75 branch December 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@MarioLulab MarioLulab MarioLulab left review comments
@0x45f 0x45f 0x45f approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@luotao1 luotao1

@0x45f 0x45f

@YuanRisheng YuanRisheng

@MarioLulab MarioLulab

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@enkilee @0x45f @MarioLulab @luotao1 @YuanRisheng