Repository navigation
【PIR API adaptor No.133-135】Migrate paddle.logical_not/logical_or/logical_xor into pir - #58781
Merged
Merged
Conversation
Closed
Contributor
Author
|
|
Collaborator
这是个已知问题,目前的话建议最好统一采用 paddle.static.Program() 写法,而不是先前 import 的 Program。具体出现问题的原因内部还在排查。这个 pr 的单测里改成 paddle.static.Program() 写法吧,可以让 pr 先合入~ |
Contributor
Author
好的,感谢^v^ |
0x45f
reviewed
Nov 9, 2023
Collaborator
|
请问 test/legacy_test/test_logical_op.py 里的 test_type_error 单测没有切换成 pir 的模式的原因是? |
Contributor
Author
Collaborator
MarioLulab
approved these changes
Nov 10, 2023
Contributor
Author
0x45f
approved these changes
Nov 10, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




PR types
Others
PR changes
APIs
Description
新IR Python API适配升级 #58067
No.133 No.134 No.135
PIR API 推全升级
将
paddle.logical_not迁移升级至 pir,并更新单测,单测覆盖率:2/2将
paddle.logical_or迁移升级至 pir,并更新单测,单测覆盖率:2/2将
paddle.logical_xor迁移升级至 pir,并更新单测,单测覆盖率:2/2test_type_error单测暂不支持,数据类型检查的工作以后会下沉到 c++ 端去执行。