Skip to content

【PIR API adaptor No.150、151、155、157、173】 Migrate qr,mv etc. into pir - #58740

Merged
0x45f merged 8 commits into
PaddlePaddle:developfrom
DrRyanHuang:qr_mv
Nov 15, 2023
Merged

0x45f merged 8 commits into
PaddlePaddle:developfrom
DrRyanHuang:qr_mv

Conversation

@DrRyanHuang

@DrRyanHuang DrRyanHuang commented Nov 6, 2023 •

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Description

PIR API 推全升级

test_errors 会报错部分:

ERROR: test_errors (test_multi_dot_op.TestMultiDotOpError) 单测覆盖率 16/17
ERROR: test_errors (test_matrix_power_op.TestMatrixPowerAPIError) 单测覆盖率 28/29

test_matrix_rank_op 单测覆盖率 100%
test_mv_op 单测覆盖率 100%
test_qr_op 单测覆盖率 100%

@MarioLulab

Copy link
Copy Markdown
Collaborator

麻烦在 PR 描述里补充单测的覆盖率 🚀

@MarioLulab MarioLulab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work ~ ⭐
还有一处地方单测遗漏,麻烦补充一下吧

Comment thread test/legacy_test/test_matrix_rank_op.py Resolved

@MarioLulab MarioLulab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f
0x45f merged commit 0dcc072 into PaddlePaddle:develop Nov 15, 2023
@DrRyanHuang
DrRyanHuang deleted the qr_mv branch November 15, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants