Skip to content

【PIR API adaptor No.22】Migrate paddle.nn.functional.bilinear into pir - #58690

Merged
0x45f merged 5 commits into
PaddlePaddle:developfrom
GreatV:pir_F_bilinear
Nov 14, 2023
Merged

0x45f merged 5 commits into
PaddlePaddle:developfrom
GreatV:pir_F_bilinear

Conversation

@GreatV

@GreatV GreatV commented Nov 4, 2023

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Description

Migrate paddle.nn.functional.bilinear into pir

@paddle-bot paddle-bot Bot added the contributor External developers label Nov 4, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 6, 2023

@MarioLulab MarioLulab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/legacy_test/test_layers.py 里有 paddle.nn.Bilinear 相关的单测,麻烦补一下吧~ 😃

Comment thread test/legacy_test/test_layers.py Resolved
@MarioLulab

MarioLulab commented Nov 8, 2023 •

Copy link
Copy Markdown
Collaborator

ci 挂在了 test_layers.py 中的 self.get_static_graph_result 函数里。这个 PR 会对这一类的问题进行 fix #58608
待问题 fix 之后再推进这个 pr 的合入吧~

@paddle-bot

paddle-bot Bot commented Nov 10, 2023

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MarioLulab

Copy link
Copy Markdown
Collaborator

ci 挂在了 test_layers.py 中的 self.get_static_graph_result 函数里。这个 PR 会对这一类的问题进行 fix #58608 待问题 fix 之后再推进这个 pr 的合入吧~

这个 pr 已经合入了。麻烦 merge 一下最新的 develop 分支,再跑一下 ci 看是否会报错~

@MarioLulab MarioLulab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GreatV
GreatV requested review from 0x45f and YuanRisheng November 14, 2023 02:02
@0x45f
0x45f merged commit 9528c7e into PaddlePaddle:develop Nov 14, 2023
@GreatV
GreatV deleted the pir_F_bilinear branch November 14, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants