Skip to content

[CodeStyle][task 29,31,32] enable ruff B019, C416 and F821 rule in python/paddle/base #58186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luotao1 merged 3 commits into from
Oct 19, 2023
Merged

[CodeStyle][task 29,31,32] enable ruff B019, C416 and F821 rule in python/paddle/base #58186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3dfb9c
fix
enkilee Oct 18, 2023
0b62fa5
Merge branch 'develop' into codestyle-B019-C416-F821
enkilee Oct 18, 2023
c8621f8
update logger
SigureMo Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,6 @@ ignore = [
# Ignore unnecessary lambda in dy2st unittest test_lambda
"test/dygraph_to_static/test_lambda.py" = ["PLC3002"]

# Temporarily ignored
"python/paddle/base/**" = [
"B019", # Confirmation required
"C416",
"F821",
]

# B017
"test/auto_parallel/spmd_rules/test_reshape_rule.py" = ["B017"]
"test/dygraph_to_static/test_assert.py" = ["B017"]
Expand Down
11 changes: 7 additions & 4 deletions python/paddle/base/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,11 @@ def _can_use_interpreter_core(program, place):
return True


@lru_cache()
def _warning_once(msg):
logging.warning(msg)


class FetchHandler:
def __init__(self, var_dict=None, period_secs=60):
assert var_dict is not None
Expand Down Expand Up @@ -1177,10 +1182,8 @@ def _add_micro_scopes_cache(self, program_cache_key, micro_scopes: list):
def _get_micro_scopes_cache(self, program_cache_key):
return self.micro_scope_cache.get(program_cache_key, None)

# just for testing, will be removed later
@lru_cache()
def _log_force_set_program_cache(self, use_program_cache):
logging.warning(
_warning_once(
f"use_program_cache is force set to {use_program_cache} by FLAGS_FORCE_USE_PROGRAM_CACHE"
)

Expand Down Expand Up @@ -2722,7 +2725,7 @@ def _run_using_fleet_executor(
if return_numpy:
tensor = as_numpy(tensor)
else:
tensor = [t for t in tensor]
tensor = list(tensor)

if tensor:
scope_result_list.append(tensor)
Expand Down
1 change: 1 addition & 0 deletions python/paddle/base/variable_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import itertools
import warnings
from functools import reduce

import numpy as np

Expand Down