Skip to content

[CodeStyle][task 18] enable Ruff C403 rule in python/paddle/base - #57397

Merged
luotao1 merged 4 commits into
PaddlePaddle:developfrom
ooooo-create:ooooo/C403
Sep 18, 2023
Merged

luotao1 merged 4 commits into
PaddlePaddle:developfrom
ooooo-create:ooooo/C403

Conversation

@ooooo-create

@ooooo-create ooooo-create commented Sep 15, 2023 •

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Description

auto fix
@gouzil

@paddle-bot

paddle-bot Bot commented Sep 15, 2023

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Sep 15, 2023
@gouzil

gouzil commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator

rerun 一下 ci, 其他的没啥问题了

@ooooo-create ooooo-create changed the title [CodeStyle][task 18] enable Ruff C403 rule in python/paddle/base [CodeStyle][task 18] enable Ruff C403 rule in python/paddle/base Sep 16, 2023
@gouzil

gouzil commented Sep 17, 2023

Copy link
Copy Markdown
Collaborator

LGTM, @SigureMo

SigureMo
SigureMo previously approved these changes Sep 17, 2023

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

Comment thread pyproject.toml
# "PLR1711", # Confirmation required
"PLR1722",
# "PLW3301", # Confirmation required
"PLW3301",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmmm,是让你在别的 PR 改,但需要等那个 PR 先 merge 呀:joy:,这样这两个 PR 必然会冲突的

算了到时候解决冲突吧

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯,我以为都会有冲突的😢,这个 pr 没 merge develop 进来之前就会和之前的有冲突?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为和 #57400 改了同一行

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57400 已合入,可以解决冲突了

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 18, 2023

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1
luotao1 merged commit d481b4f into PaddlePaddle:develop Sep 18, 2023
@ooooo-create
ooooo-create deleted the ooooo/C403 branch September 23, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants