[WIP][clang-tidy] add clang-tidy check in the end of PR-CI-Build

.clang-tidy

@@ -1,206 +1,206 @@
 ---
 Checks: '
 bugprone-argument-comment,
--bugprone-assert-side-effect,
--bugprone-bad-signal-to-kill-thread,
--bugprone-bool-pointer-implicit-conversion,
+bugprone-assert-side-effect,
+bugprone-bad-signal-to-kill-thread,
+bugprone-bool-pointer-implicit-conversion,
 bugprone-branch-clone,
 bugprone-copy-constructor-init,
--bugprone-dangling-handle,
--bugprone-dynamic-static-initializers,
+bugprone-dangling-handle,
+bugprone-dynamic-static-initializers,
 bugprone-exception-escape,
--bugprone-fold-init-type,
--bugprone-forwarding-reference-overload,
--bugprone-inaccurate-erase,
+bugprone-fold-init-type,
+bugprone-forwarding-reference-overload,
+bugprone-inaccurate-erase,
 bugprone-incorrect-roundings,
--bugprone-infinite-loop,
+bugprone-infinite-loop,
 bugprone-integer-division,
--bugprone-macro-repeated-side-effects,
--bugprone-misplaced-operator-in-strlen-in-alloc,
+bugprone-macro-repeated-side-effects,
+bugprone-misplaced-operator-in-strlen-in-alloc,
 bugprone-misplaced-widening-cast,
--bugprone-move-forwarding-reference,
--bugprone-multiple-statement-macro,
+bugprone-move-forwarding-reference,
+bugprone-multiple-statement-macro,
 bugprone-narrowing-conversions,
--bugprone-not-null-terminated-result,
--bugprone-parent-virtual-call,
--bugprone-posix-return,
+bugprone-not-null-terminated-result,
+bugprone-parent-virtual-call,
+bugprone-posix-return,
 bugprone-signed-char-misuse,
--bugprone-sizeof-container,
--bugprone-sizeof-expression,
--bugprone-string-constructor,
--bugprone-string-integer-assignment,
--bugprone-string-literal-with-embedded-nul,
--bugprone-suspicious-enum-usage,
--bugprone-suspicious-memset-usage,
+bugprone-sizeof-container,
+bugprone-sizeof-expression,
+bugprone-string-constructor,
+bugprone-string-integer-assignment,
+bugprone-string-literal-with-embedded-nul,
+bugprone-suspicious-enum-usage,
+bugprone-suspicious-memset-usage,
 bugprone-suspicious-missing-comma,
--bugprone-suspicious-semicolon,
--bugprone-suspicious-string-compare,
--bugprone-terminating-continue,
--bugprone-throw-keyword-missing,
--bugprone-too-small-loop-variable,
--bugprone-undefined-memory-manipulation,
--bugprone-undelegated-constructor,
+bugprone-suspicious-semicolon,
+bugprone-suspicious-string-compare,
+bugprone-terminating-continue,
+bugprone-throw-keyword-missing,
+bugprone-too-small-loop-variable,
+bugprone-undefined-memory-manipulation,
+bugprone-undelegated-constructor,
 bugprone-unhandled-self-assignment,
 bugprone-unused-raii,
 bugprone-unused-return-value,
 bugprone-use-after-move,
--bugprone-virtual-near-miss,
--clang-analyzer-apiModeling.StdCLibraryFunctions,
--clang-analyzer-apiModeling.TrustNonnull,
--clang-analyzer-apiModeling.google.GTest,
--clang-analyzer-apiModeling.llvm.CastValue,
--clang-analyzer-apiModeling.llvm.ReturnValue,
+bugprone-virtual-near-miss,
+clang-analyzer-apiModeling.StdCLibraryFunctions,
+clang-analyzer-apiModeling.TrustNonnull,
+clang-analyzer-apiModeling.google.GTest,
+clang-analyzer-apiModeling.llvm.CastValue,
+clang-analyzer-apiModeling.llvm.ReturnValue,
 clang-analyzer-core.CallAndMessage,
--clang-analyzer-core.DivideZero,
--clang-analyzer-core.DynamicTypePropagation,
+clang-analyzer-core.DivideZero,
+clang-analyzer-core.DynamicTypePropagation,
 clang-analyzer-core.NonNullParamChecker,
--clang-analyzer-core.NonnilStringConstants,
--clang-analyzer-core.NullDereference,
--clang-analyzer-core.StackAddrEscapeBase,
--clang-analyzer-core.StackAddressEscape,
+clang-analyzer-core.NonnilStringConstants,
+clang-analyzer-core.NullDereference,
+clang-analyzer-core.StackAddrEscapeBase,
+clang-analyzer-core.StackAddressEscape,
 clang-analyzer-core.UndefinedBinaryOperatorResult,
--clang-analyzer-core.VLASize,
--clang-analyzer-core.builtin.BuiltinFunctions,
--clang-analyzer-core.builtin.NoReturnFunctions,
--clang-analyzer-core.uninitialized.ArraySubscript,
+clang-analyzer-core.VLASize,
+clang-analyzer-core.builtin.BuiltinFunctions,
+clang-analyzer-core.builtin.NoReturnFunctions,
+clang-analyzer-core.uninitialized.ArraySubscript,
 clang-analyzer-core.uninitialized.Assign,
--clang-analyzer-core.uninitialized.Branch,
--clang-analyzer-core.uninitialized.CapturedBlockVariable,
--clang-analyzer-core.uninitialized.UndefReturn,
+clang-analyzer-core.uninitialized.Branch,
+clang-analyzer-core.uninitialized.CapturedBlockVariable,
+clang-analyzer-core.uninitialized.UndefReturn,
 clang-analyzer-cplusplus.InnerPointer,
--clang-analyzer-cplusplus.Move,
--clang-analyzer-cplusplus.NewDelete,
--clang-analyzer-cplusplus.NewDeleteLeaks,
--clang-analyzer-cplusplus.PureVirtualCall,
--clang-analyzer-cplusplus.SelfAssignment,
--clang-analyzer-cplusplus.SmartPtr,
--clang-analyzer-cplusplus.VirtualCallModeling,
+clang-analyzer-cplusplus.Move,
+clang-analyzer-cplusplus.NewDelete,
+clang-analyzer-cplusplus.NewDeleteLeaks,
+clang-analyzer-cplusplus.PureVirtualCall,
+clang-analyzer-cplusplus.SelfAssignment,
+clang-analyzer-cplusplus.SmartPtr,
+clang-analyzer-cplusplus.VirtualCallModeling,
 clang-analyzer-deadcode.DeadStores,
--clang-analyzer-fuchsia.HandleChecker,
--clang-analyzer-nullability.NullPassedToNonnull,
--clang-analyzer-nullability.NullReturnedFromNonnull,
--clang-analyzer-nullability.NullabilityBase,
--clang-analyzer-nullability.NullableDereferenced,
--clang-analyzer-nullability.NullablePassedToNonnull,
--clang-analyzer-nullability.NullableReturnedFromNonnull,
+clang-analyzer-fuchsia.HandleChecker,
+clang-analyzer-nullability.NullPassedToNonnull,
+clang-analyzer-nullability.NullReturnedFromNonnull,
+clang-analyzer-nullability.NullabilityBase,
+clang-analyzer-nullability.NullableDereferenced,
+clang-analyzer-nullability.NullablePassedToNonnull,
+clang-analyzer-nullability.NullableReturnedFromNonnull,
 clang-analyzer-optin.cplusplus.UninitializedObject,
--clang-analyzer-optin.cplusplus.VirtualCall,
--clang-analyzer-optin.mpi.MPI-Checker,
--clang-analyzer-optin.osx.OSObjectCStyleCast,
--clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
--clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,
--clang-analyzer-optin.performance.GCDAntipattern,
--clang-analyzer-optin.performance.Padding,
+clang-analyzer-optin.cplusplus.VirtualCall,
+clang-analyzer-optin.mpi.MPI-Checker,
+clang-analyzer-optin.osx.OSObjectCStyleCast,
+clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
+clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,
+clang-analyzer-optin.performance.GCDAntipattern,
+clang-analyzer-optin.performance.Padding,
 clang-analyzer-optin.portability.UnixAPI,
--clang-analyzer-osx.API,
--clang-analyzer-osx.MIG,
--clang-analyzer-osx.NSOrCFErrorDerefChecker,
--clang-analyzer-osx.NumberObjectConversion,
--clang-analyzer-osx.OSObjectRetainCount,
--clang-analyzer-osx.ObjCProperty,
--clang-analyzer-osx.SecKeychainAPI,
--clang-analyzer-osx.cocoa.AtSync,
--clang-analyzer-osx.cocoa.AutoreleaseWrite,
--clang-analyzer-osx.cocoa.ClassRelease,
--clang-analyzer-osx.cocoa.Dealloc,
--clang-analyzer-osx.cocoa.IncompatibleMethodTypes,
--clang-analyzer-osx.cocoa.Loops,
--clang-analyzer-osx.cocoa.MissingSuperCall,
--clang-analyzer-osx.cocoa.NSAutoreleasePool,
--clang-analyzer-osx.cocoa.NSError,
--clang-analyzer-osx.cocoa.NilArg,
--clang-analyzer-osx.cocoa.NonNilReturnValue,
--clang-analyzer-osx.cocoa.ObjCGenerics,
--clang-analyzer-osx.cocoa.RetainCount,
--clang-analyzer-osx.cocoa.RetainCountBase,
--clang-analyzer-osx.cocoa.RunLoopAutoreleaseLeak,
--clang-analyzer-osx.cocoa.SelfInit,
--clang-analyzer-osx.cocoa.SuperDealloc,
--clang-analyzer-osx.cocoa.UnusedIvars,
--clang-analyzer-osx.cocoa.VariadicMethodTypes,
--clang-analyzer-osx.coreFoundation.CFError,
--clang-analyzer-osx.coreFoundation.CFNumber,
--clang-analyzer-osx.coreFoundation.CFRetainRelease,
--clang-analyzer-osx.coreFoundation.containers.OutOfBounds,
--clang-analyzer-osx.coreFoundation.containers.PointerSizedValues,
--clang-analyzer-security.FloatLoopCounter,
--clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
--clang-analyzer-security.insecureAPI.SecuritySyntaxChecker,
--clang-analyzer-security.insecureAPI.UncheckedReturn,
--clang-analyzer-security.insecureAPI.bcmp,
--clang-analyzer-security.insecureAPI.bcopy,
--clang-analyzer-security.insecureAPI.bzero,
--clang-analyzer-security.insecureAPI.decodeValueOfObjCType,
--clang-analyzer-security.insecureAPI.getpw,
--clang-analyzer-security.insecureAPI.gets,
--clang-analyzer-security.insecureAPI.mkstemp,
--clang-analyzer-security.insecureAPI.mktemp,
--clang-analyzer-security.insecureAPI.rand,
--clang-analyzer-security.insecureAPI.strcpy,
+clang-analyzer-osx.API,
+clang-analyzer-osx.MIG,
+clang-analyzer-osx.NSOrCFErrorDerefChecker,
+clang-analyzer-osx.NumberObjectConversion,
+clang-analyzer-osx.OSObjectRetainCount,
+clang-analyzer-osx.ObjCProperty,
+clang-analyzer-osx.SecKeychainAPI,
+clang-analyzer-osx.cocoa.AtSync,
+clang-analyzer-osx.cocoa.AutoreleaseWrite,
+clang-analyzer-osx.cocoa.ClassRelease,
+clang-analyzer-osx.cocoa.Dealloc,
+clang-analyzer-osx.cocoa.IncompatibleMethodTypes,
+clang-analyzer-osx.cocoa.Loops,
+clang-analyzer-osx.cocoa.MissingSuperCall,
+clang-analyzer-osx.cocoa.NSAutoreleasePool,
+clang-analyzer-osx.cocoa.NSError,
+clang-analyzer-osx.cocoa.NilArg,
+clang-analyzer-osx.cocoa.NonNilReturnValue,
+clang-analyzer-osx.cocoa.ObjCGenerics,
+clang-analyzer-osx.cocoa.RetainCount,
+clang-analyzer-osx.cocoa.RetainCountBase,
+clang-analyzer-osx.cocoa.RunLoopAutoreleaseLeak,
+clang-analyzer-osx.cocoa.SelfInit,
+clang-analyzer-osx.cocoa.SuperDealloc,
+clang-analyzer-osx.cocoa.UnusedIvars,
+clang-analyzer-osx.cocoa.VariadicMethodTypes,
+clang-analyzer-osx.coreFoundation.CFError,
+clang-analyzer-osx.coreFoundation.CFNumber,
+clang-analyzer-osx.coreFoundation.CFRetainRelease,
+clang-analyzer-osx.coreFoundation.containers.OutOfBounds,
+clang-analyzer-osx.coreFoundation.containers.PointerSizedValues,
+clang-analyzer-security.FloatLoopCounter,
+clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
+clang-analyzer-security.insecureAPI.SecuritySyntaxChecker,
+clang-analyzer-security.insecureAPI.UncheckedReturn,
+clang-analyzer-security.insecureAPI.bcmp,
+clang-analyzer-security.insecureAPI.bcopy,
+clang-analyzer-security.insecureAPI.bzero,
+clang-analyzer-security.insecureAPI.decodeValueOfObjCType,
+clang-analyzer-security.insecureAPI.getpw,
+clang-analyzer-security.insecureAPI.gets,
+clang-analyzer-security.insecureAPI.mkstemp,
+clang-analyzer-security.insecureAPI.mktemp,
+clang-analyzer-security.insecureAPI.rand,
+clang-analyzer-security.insecureAPI.strcpy,
 clang-analyzer-security.insecureAPI.vfork,
--clang-analyzer-unix.API,
--clang-analyzer-unix.DynamicMemoryModeling,
+clang-analyzer-unix.API,
+clang-analyzer-unix.DynamicMemoryModeling,
 clang-analyzer-unix.Malloc,
--clang-analyzer-unix.MallocSizeof,
--clang-analyzer-unix.MismatchedDeallocator,
+clang-analyzer-unix.MallocSizeof,
+clang-analyzer-unix.MismatchedDeallocator,
 clang-analyzer-unix.Vfork,
--clang-analyzer-unix.cstring.BadSizeArg,
--clang-analyzer-unix.cstring.CStringModeling,
--clang-analyzer-unix.cstring.NullArg,
--clang-analyzer-valist.CopyToSelf,
--clang-analyzer-valist.Uninitialized,
--clang-analyzer-valist.Unterminated,
--clang-analyzer-valist.ValistBase,
+clang-analyzer-unix.cstring.BadSizeArg,
+clang-analyzer-unix.cstring.CStringModeling,
+clang-analyzer-unix.cstring.NullArg,
+clang-analyzer-valist.CopyToSelf,
+clang-analyzer-valist.Uninitialized,
+clang-analyzer-valist.Unterminated,
+clang-analyzer-valist.ValistBase,
 cppcoreguidelines-avoid-c-arrays,
--cppcoreguidelines-avoid-goto,
+cppcoreguidelines-avoid-goto,
 cppcoreguidelines-c-copy-assignment-signature,
 cppcoreguidelines-explicit-virtual-functions,
 cppcoreguidelines-init-variables,
 cppcoreguidelines-narrowing-conversions,
 cppcoreguidelines-no-malloc,
 cppcoreguidelines-pro-type-const-cast,
--cppcoreguidelines-pro-type-member-init,
--cppcoreguidelines-slicing,
--hicpp-avoid-goto,
+cppcoreguidelines-pro-type-member-init,
+cppcoreguidelines-slicing,
+hicpp-avoid-goto,
 hicpp-exception-baseclass,
 misc-unused-alias-decls,
 misc-unused-using-decls,
 modernize-avoid-bind,
 modernize-avoid-c-arrays,
 modernize-deprecated-headers,
--modernize-deprecated-ios-base-aliases,
+modernize-deprecated-ios-base-aliases,
 modernize-loop-convert,
 modernize-make-shared,
 modernize-make-unique,
--modernize-pass-by-value,
+modernize-pass-by-value,
 modernize-raw-string-literal,
 modernize-redundant-void-arg,
--modernize-replace-auto-ptr,
--modernize-replace-random-shuffle,
--modernize-shrink-to-fit,
--modernize-unary-static-assert,
+modernize-replace-auto-ptr,
+modernize-replace-random-shuffle,
+modernize-shrink-to-fit,
+modernize-unary-static-assert,
 modernize-use-bool-literals,
 modernize-use-emplace,
 modernize-use-equals-default,
--modernize-use-equals-delete,
--modernize-use-noexcept,
+modernize-use-equals-delete,
+modernize-use-noexcept,
 modernize-use-nullptr,
 modernize-use-override,
 modernize-use-transparent-functors,
--modernize-use-uncaught-exceptions,
+modernize-use-uncaught-exceptions,
 performance-faster-string-find,
 performance-for-range-copy,
--performance-implicit-conversion-in-loop,
--performance-inefficient-algorithm,
+performance-implicit-conversion-in-loop,
+performance-inefficient-algorithm,
 performance-inefficient-string-concatenation,
--performance-inefficient-vector-operation,
+performance-inefficient-vector-operation,
 performance-move-const-arg,
--performance-move-constructor-init,
--performance-no-automatic-move,
+performance-move-constructor-init,
+performance-no-automatic-move,
 performance-noexcept-move-constructor,
--performance-trivially-destructible,
--performance-type-promotion-in-math-fn,
--performance-unnecessary-copy-initialization,
+performance-trivially-destructible,
+performance-type-promotion-in-math-fn,
+performance-unnecessary-copy-initialization,
 readability-container-size-empty,
 '
 HeaderFilterRegex: '^(paddle/(?!cinn)).*$'

.pre-commit-config.yaml

@@ -102,6 +102,7 @@ repos:
         files: \.(c|cc|cxx|cpp|h|hpp|hxx)$
         args:
             - -p=build/
+            - -clang-tidy-binary=clang-tidy
             - -extra-arg=-Wno-unknown-warning-option
             - -extra-arg=-Wno-pessimizing-move
             - -extra-arg=-Wno-braced-scalar-init

paddle/fluid/framework/ir/mkldnn/cpu_quantize_pass_tester.cc

@@ -754,7 +754,7 @@ const std::vector<std::string> churn_out_vars(ProgramDesc* prog,
 
 void create_vars(ProgramDesc* prog,
                  const std::initializer_list<std::string>& names) {
-  for (auto name : names) prog->MutableBlock(0)->Var(name);
+  for (auto const& name : names) prog->MutableBlock(0)->Var(name);
 }
 
 void SetMultiGruOp(ProgramDesc* prog,

paddle/fluid/framework/ir/quantize_helper.cc

@@ -38,7 +38,7 @@ std::unordered_map<std::string, std::vector<float>> GetQuantInfoFromTheGraph(
   const std::string suffix = "_" + key_suffix + "_" + flag;
   if (graph->Has(flag)) {
     std::vector<std::string> attr_names = graph->AttrNames();
-    for (auto fake_name : attr_names) {
+    for (auto const& fake_name : attr_names) {
       size_t pos = fake_name.find(suffix);
       if (pos != std::string::npos) {
         std::string name = fake_name.substr(0, pos);

paddle/fluid/framework/new_executor/interpreter/plan.cc

@@ -68,7 +68,7 @@ const std::vector<std::shared_ptr<Job>>& Plan::JobList() const {
 
 const std::vector<std::string> Plan::JobTypes() const {
   std::vector<std::string> res;
-  for (auto kv : type_to_ir_program_) {
+  for (auto const& kv : type_to_ir_program_) {
     res.emplace_back(kv.first);
   }
   return res;

paddle/fluid/pir/transforms/inplace_pass.cc

@@ -424,7 +424,7 @@ static std::unordered_map<pir::Operation*, std::string> GetInplaceOps(
     }
   }
   if (!FLAGS_ir_inplace_kernel_blacklist.empty()) {
-    for (auto i : inplace_ops) {
+    for (auto const& i : inplace_ops) {
       std::cout << i.second << std::endl;
     }
   }