Repository navigation
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
luotao1
approved these changes
Mar 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
同 #52019,只不过这次是加上 pylint 部分(之前没想到这么快就做到 pylint 了,而且调研也需要花些时间……)
本次更新添加了 #52025 忘记更新的 UP027(原来是有的,应该是后来解决冲突解决错了)
此外引入以下无存量 Pylint rules:
__init__函数不应该 yield,是明显的错误,可以引入__all__用于标志from package import *时会将哪些成员引入到当前 namespace,在 Paddle 主要用来标识 public 的 API,其类型应该为list[str],本 rule 用于确保每个元素都是 str,可以引入Related links