[gouzil]

PR types

Others

PR changes

Others

Describe

将hasattr(x, '__call__')改写为 callable(x)前者是不可靠的，(相关文档 builtins - hasattr 、builtins - callable)

B004	Using hasattr(x, '__call__') to test if x is callable is unreliable. If x implements custom __getattr__ or its __call__ is itself not callable, you might get misleading results. Use callable(x) for consistent results.

是否可以引入本 rule：✅ 如上所述，可以引入
是否可引入自动修复：❌手动修复

修复方法如下:

将python/paddle/jit/dy2static/convert_call_func.py 文件下的

elif hasattr(func, '__class__') and hasattr(func.__class__, '__call__'):

修改为

elif hasattr(func, '__class__') and callable(func.__class__):

Related links

• Tracking issue: Introducing Ruff tracking issue #51729
• RFC: add RFC of introducing ruff community#412
• Ruff docs: flake8-bugbear-b

[paddle-bot]

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

[SigureMo]

@Aurelius84 求帮看看这里的修改是否算是一种改进，或者是否会导致出现一些边界 case，我这边看了下觉得改不改区别不大

callable(x) 和 hasattr(x, "__call__") 对比可见 https://stackoverflow.com/questions/16388059/using-callablex-vs-hasattrx-call

[Aurelius84]

可以改为callable，似乎比hasattr语义更明确一些：

class A(object):
    def __getattr__(self, name):
        return name
    

a = A()

print(hasattr(a, "__call__"))  # True
print(callable(a))  # False

[SigureMo]

LGTM