Skip to content

[CodeStyle][F401][NPU] remove unused imports in unittests/npu - #46782

Closed
SigureMo wants to merge 6 commits into
PaddlePaddle:developfrom
cattidea:F401/fix/unittests-npu
Closed

SigureMo wants to merge 6 commits into
PaddlePaddle:developfrom
cattidea:F401/fix/unittests-npu

Conversation

@SigureMo

@SigureMo SigureMo commented Oct 8, 2022 •

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Describe

修复 python/paddle/fluid/tests/unittests/npu/ 目录 F401 unused import 存量

autoflake --in-place --remove-all-unused-imports --ignore-pass-after-docstring --exclude=__init__.py --recursive ./python/paddle/fluid/tests/unittests/npu/

Related links

@paddle-bot

paddle-bot Bot commented Oct 8, 2022

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added contributor External developers status: proposed labels Oct 8, 2022
@paddle-bot

paddle-bot Bot commented Oct 8, 2022 •

Copy link
Copy Markdown

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@SigureMo SigureMo changed the title [WIP][NPU][CodeStyle][F401] remove unused import in unittests/npu [WIP][NPU][CodeStyle][F401] remove unused imports in unittests/npu Oct 8, 2022
@SigureMo SigureMo changed the title [WIP][NPU][CodeStyle][F401] remove unused imports in unittests/npu [WIP][CodeStyle][F401] remove unused imports in unittests/npu Oct 8, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle][F401] remove unused imports in unittests/npu [WIP][CodeStyle][F401][NPU] remove unused imports in unittests/npu Oct 8, 2022
@SigureMo

SigureMo commented Oct 8, 2022

Copy link
Copy Markdown
Collaborator Author

image

虽然 NPU 流水线是 pass 的,但貌似没有任何单测运行,这里的这个问题我尝试了下在没有任何改动的情况下也是存在的,不是本 PR 导致的

@SigureMo SigureMo changed the title [WIP][CodeStyle][F401][NPU] remove unused imports in unittests/npu [CodeStyle][F401][NPU] remove unused imports in unittests/npu Oct 8, 2022
@luotao1 luotao1 self-assigned this Oct 10, 2022
@luotao1

luotao1 commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

@qili93 可以看下NPU流水线失败的问题

@qili93

qili93 commented Oct 10, 2022 •

Copy link
Copy Markdown
Collaborator

hi, NPU 相关代码与功能目前 90% 已经迁移到 https://github.com/PaddlePaddle/PaddleCustomDevice/tree/develop/backends/npu ,预计 Q4 会从主框架删除 NPU相关代码,建议此 PR关闭。

@SigureMo

Copy link
Copy Markdown
Collaborator Author

hi, NPU 相关代码与功能目前 90% 已经迁移到 https://github.com/PaddlePaddle/PaddleCustomDevice/tree/develop/backends/npu?rgh-link-date=2022-10-10T09%3A28%3A05Z ,预计 Q4 会从主框架删除 NPU相关代码,建议此 PR关闭。

好的,我会在 Flake8 相关配置里全局 exclude 掉 NPU 相关代码,直到 NPU 相关代码彻底移除

我看了下该 repo 同样有 mlu 代码,请问 mlu 是否有同样(从主框架删除的)计划呢?

@luotao1

luotao1 commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

我看了下该 repo 同样有 mlu 代码,请问 mlu 是否有同样(从主框架删除的)计划呢?

和 @qili93 讨论了,mlu预计明年Q1有删除计划,因此路径中包含 npu/mlu 的目录都可以不做格式修复了。

@SigureMo

Copy link
Copy Markdown
Collaborator Author

和 @qili93 讨论了,mlu预计明年Q1有删除计划,因此路径中包含 npu/mlu 的目录都可以不做格式修复了。

好的,我会在这个的配置修改里 exclude 掉这俩目录,并 close 这俩 PR~

@paddle-bot

paddle-bot Bot commented Oct 10, 2022

Copy link
Copy Markdown

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@SigureMo
SigureMo deleted the F401/fix/unittests-npu branch October 10, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F401] python/paddle/fluid/tests/unittests/npu

3 participants