Repository navigation
[CodeStyle][F401] remove unused imports in python/paddle/distributed - #46758
Merged
luotao1 merged 17 commits intoOct 12, 2022
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Fix ValueError: list.remove(x): x not in list for meta_optimizer_names.
Fix split import.
This reverts commit 6172bea.
This comment was marked as outdated.
This comment was marked as outdated.
SigureMo
changed the title
SigureMo
changed the title
SigureMo
commented
Oct 10, 2022
| # limitations under the License. | ||
|
|
||
| from paddle.distributed.fleet.meta_optimizers.common import is_optimizer_op, OP_ROLE_KEY, OpRole | ||
| from paddle.distributed.fleet.meta_optimizers.sharding.utils import * |
Collaborator
Author
There was a problem hiding this comment.
由于这行的存在，导致暴露了 API add_sync_comm 在 paddle.distributed.fleet.meta_optimizers.sharding.fp16_helper.add_sync_comm 暴露（develop 下直接运行 python tools/count_api_without_core_ops.py -c paddle 即可看到本 API），但这个 API 的暴露应该并不是预期的，而删除本 import 后则会导致 API 路径变动为 paddle.distributed.fleet.meta_optimizers.sharding.utils.add_sync_comm，因此会被认为「新增」API，触发本 CI 拦截
SigureMo
changed the title
luotao1
approved these changes
Oct 11, 2022
Ligoml
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
修复
python/paddle/fluid/tests/unittests/distributed/目录 F401 unused import 存量 python 代码Related links