Skip to content

[CodeStyle][F522] Remove unused arguments #46743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luotao1 merged 4 commits into from
Oct 24, 2022
Merged

[CodeStyle][F522] Remove unused arguments #46743

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38636d5
Fix F522: remove unused arguments
caolonghao Oct 4, 2022
c4eab7b
add redirect_stderr argument in _run_cmd
caolonghao Oct 17, 2022
f3acb9f
Merge branch 'develop' into F522/fix
caolonghao Oct 17, 2022
1d627ca
Merge branch 'develop' into F522/fix
caolonghao Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/paddle/distributed/fleet/utils/fs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,8 @@ def is_dir(self, fs_path):
return self._is_dir(fs_path)

def _is_dir(self, fs_path):
cmd = "test -d {}".format(fs_path, redirect_stderr=True)
ret, lines = self._run_cmd(cmd, retry_times=1)
cmd = "test -d {}".format(fs_path)

@SigureMo SigureMo Oct 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我怀疑是想将 redirect_stderr=True 插入到下一行的 _run_cmd 里，结果误插入到了这个 format 这里 😂，具体怎么改工作日讨论下吧，这里就先别动啦～

当然目前这么改是没有任何问题的，不会对现有代码造成任何影响～

ret, lines = self._run_cmd(cmd, redirect_stderr=True, retry_times=1)
if ret:
# other error
if self._test_match(lines):
Expand Down