Skip to content

[CodeStyle] trailing whitespace hook for .hook and .yaml #46081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luotao1 merged 8 commits into from
Sep 19, 2022
+5 −1
Merged

[CodeStyle] trailing whitespace hook for .hook and .yaml #46081

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a3f4717
adjust pre-commit config
SigureMo Sep 15, 2022
10235b2
Merge branch 'develop' into trailing-whitespace-increment
SigureMo Sep 15, 2022
2d1e065
incremental trailing whitespace
SigureMo Sep 15, 2022
b2c7ac4
revert python increment, fix in #46080
SigureMo Sep 15, 2022
818a8e5
add .yaml and .hook suffix to pre-commit config, test=document_fix
SigureMo Sep 15, 2022
25a3b0d
Merge branch 'develop' into trailing-whitespace-increment
SigureMo Sep 15, 2022
bb527d2
Merge branch 'develop' into trailing-whitespace-increment
SigureMo Sep 16, 2022
cc3e114
add yml suffix
SigureMo Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
exclude: |
(?x)^(
patches/.+
)$

@SigureMo SigureMo Sep 15, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接全局排除掉这些文件，避免每个 hook 下都写一遍

参考：.pre-commit-config.yaml - top level

repos:
- repo: https://github.com/Lucas-C/pre-commit-hooks.git
rev: v1.1.14
Expand Down Expand Up @@ -26,7 +30,7 @@ repos:
- id: sort-simple-yaml
files: (api|backward|api_[a-z_]+)\.yaml$
- id: trailing-whitespace
files: (.*\.(py|bzl|md|rst|c|cc|cxx|cpp|cu|h|hpp|hxx|xpu|kps|cmake)|BUILD|.*\.BUILD|WORKSPACE|CMakeLists.txt)$
files: (.*\.(py|bzl|md|rst|c|cc|cxx|cpp|cu|h|hpp|hxx|xpu|kps|cmake|yaml|yml|hook)|BUILD|.*\.BUILD|WORKSPACE|CMakeLists\.txt)$

@SigureMo SigureMo Sep 16, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加了 yml 后缀的 yaml 文件，为 GitHub issue form 模板，trailing whitespace 不会影响渲染效果，存量也在相应 PR 修复

- repo: local
hooks:
- id: clang-format
Expand Down