Repository navigation
Fix test_origin_info to be compatible with PY3.8, because ast module is different in PY3.8 - #27201
Merged
Merged
Conversation
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
…is different in PY3.8 test=develop Change-Id: Ib574a43789e6cbb053ca70d1f0a371f6149ea692
liym27
force-pushed
the
fix_test_origin_info_PY38
branch
from
September 9, 2020 07:04
1c782c4 to
5a11be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
Fix test_origin_info to be compatible with PY3.8, because ast module is different in PY3.8
There are differences in ast_node.lineno between PY3.8+ and PY3.8-.
If the first gast.FunctionDef has decorator, the lineno of gast.FunctionDef is differs.
its lineno equals to the lineno of the first decorator node, which is not right.
its lineno is the actual lineno, which is right.