[Optimization] Avoid unnecessary penalty computation - #6078
Merged
Merged
Conversation
|
Thanks for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6078 +/- ##
==========================================
Coverage ? 67.42%
==========================================
Files ? 350
Lines ? 45320
Branches ? 6967
==========================================
Hits ? 30559
Misses ? 12521
Partials ? 2240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…into opt_penalty
Sunny-bot1
commented
Jan 19, 2026
Comment on lines
+72
to
+77
| float alpha = penalty_scores[bi]; | ||
| float beta = frequency_score[bi]; | ||
| float gamma = presence_score[bi]; | ||
| if (alpha == 1.f && beta == 0.f && gamma == 0.f) { | ||
| return; | ||
| } |
Sunny-bot1
commented
Jan 19, 2026
Comment on lines
+125
to
+127
| if (alpha == 1.f && beta == 0.f && gamma == 0.f && temperature == 1.f) { | ||
| return; | ||
| } |
zhoutianzi666
approved these changes
Jan 19, 2026
LLSGYN
pushed a commit
to LLSGYN/FastDeploy
that referenced
this pull request
Feb 2, 2026
chang-wenbin
pushed a commit
to chang-wenbin/FastDeploy
that referenced
this pull request
Mar 2, 2026
xiaoguoguo626807
pushed a commit
to xiaoguoguo626807/FastDeploy
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
重复惩罚计算后处理耗时占比高，但很多时候我们没有传入penalty score，无需进行这些计算
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.