Skip to content

[BugFix] fix mm revert bug - #6061

Merged
yuanlehome merged 2 commits into
PaddlePaddle:developfrom
kevincheng2:fix_revert_bug
Jan 16, 2026
Merged

yuanlehome merged 2 commits into
PaddlePaddle:developfrom
kevincheng2:fix_revert_bug

Conversation

@kevincheng2

@kevincheng2 kevincheng2 commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

Motivation

修复两个边界case:

  1. 当cache刚好命中图片起始位置的token时,请求会hang在 revert_chunked_mm_input 方法中
  2. 当切chunk刚好切到图片起始位置时,会丢失图片信息

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot

paddle-bot Bot commented Jan 16, 2026

Copy link
Copy Markdown

Thanks for your contribution!

@codecov-commenter

codecov-commenter commented Jan 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@b2a2e11). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/engine/sched/resource_manager_v1.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6061   +/-   ##
==========================================
  Coverage           ?   67.42%           
==========================================
  Files              ?      350           
  Lines              ?    45319           
  Branches           ?     6966           
==========================================
  Hits               ?    30557           
  Misses             ?    12523           
  Partials           ?     2239           
Flag Coverage Δ
GPU 67.42% <20.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yuanlehome pushed a commit that referenced this pull request Jan 16, 2026
@yuanlehome
yuanlehome merged commit 0e0eaa1 into PaddlePaddle:develop Jan 16, 2026
16 of 20 checks passed
yuanlehome pushed a commit that referenced this pull request Jan 16, 2026
@kevincheng2
kevincheng2 deleted the fix_revert_bug branch January 19, 2026 03:41
LLSGYN pushed a commit to LLSGYN/FastDeploy that referenced this pull request Feb 2, 2026
* fix mm revert bug

* update code
chang-wenbin pushed a commit to chang-wenbin/FastDeploy that referenced this pull request Mar 2, 2026
* fix mm revert bug

* update code
xiaoguoguo626807 pushed a commit to xiaoguoguo626807/FastDeploy that referenced this pull request May 7, 2026
* fix mm revert bug

* update code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants