Skip to content

[Optimization] Do not compute ATTN padding part in In Cuda graph mode - #5985

Merged
zhoutianzi666 merged 6 commits into
PaddlePaddle:developfrom
zhoutianzi666:remove_cudaMemsetAsync
Jan 13, 2026
Merged

zhoutianzi666 merged 6 commits into
PaddlePaddle:developfrom
zhoutianzi666:remove_cudaMemsetAsync

Conversation

@zhoutianzi666

@zhoutianzi666 zhoutianzi666 commented Jan 11, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Do not compute ATTN padding part in In Cuda graph mode

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

Do not compute ATTN padding part in In Cuda graph mode

Usage or Command

None

Accuracy Tests

None

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot

paddle-bot Bot commented Jan 11, 2026

Copy link
Copy Markdown

Thanks for your contribution!

@codecov-commenter

codecov-commenter commented Jan 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@1aa7e82). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5985   +/-   ##
==========================================
  Coverage           ?   66.58%           
==========================================
  Files              ?      347           
  Lines              ?    44634           
  Branches           ?     6877           
==========================================
  Hits               ?    29719           
  Misses             ?    12717           
  Partials           ?     2198           
Flag Coverage Δ
GPU 66.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhoutianzi666 zhoutianzi666 changed the title commit remove useless code Jan 11, 2026
@zhoutianzi666 zhoutianzi666 changed the title remove useless code Do not compute attn padding part in Jan 12, 2026
[max_num_seqs, 1], self.model_config.max_model_len, dtype="int64"
)
self.seq_lens_this_time_buffer = paddle.full([max_num_seqs, 1], 0, dtype="int32")
if self.fd_config.parallel_config.enable_expert_parallel:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个感觉没啥用,删了吧

const int sliding_window) {
const auto token_num = meta_data.token_nums;
const auto block_size = meta_data.block_size;
const auto bsz = meta_data.batch_size;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只删了这个没用的东西,其他地方没动

const int sliding_window) {
const auto token_num = meta_data.token_nums;
const auto block_size = meta_data.block_size;
const auto bsz = meta_data.batch_size;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只删了这个没用的东西,其他地方没动

const int sliding_window) {
const auto token_num = meta_data.token_nums;
const auto block_size = meta_data.block_size;
const auto bsz = meta_data.batch_size;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只删了这个没用的东西,其他地方没动

@zhoutianzi666 zhoutianzi666 changed the title Do not compute attn padding part in Do not compute ATTN padding part in Jan 12, 2026
@zhoutianzi666 zhoutianzi666 changed the title Do not compute ATTN padding part in Do not compute ATTN padding part in In Cuda graph mode Jan 12, 2026
@zhoutianzi666 zhoutianzi666 changed the title Do not compute ATTN padding part in In Cuda graph mode [Optimization] Do not compute ATTN padding part in In Cuda graph mode Jan 13, 2026
@zhoutianzi666
zhoutianzi666 merged commit ad8d05a into PaddlePaddle:develop Jan 13, 2026
18 of 21 checks passed
@zhoutianzi666
zhoutianzi666 deleted the remove_cudaMemsetAsync branch February 11, 2026 02:43
xiaoguoguo626807 pushed a commit to xiaoguoguo626807/FastDeploy that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants