[BUG FIX][SOT] Fix parameter order for custom op: rms_norm_eps - #3348
Merged
Merged
Conversation
|
Thanks for your contribution! |
xiaoguoguo626807
pushed a commit
to xiaoguoguo626807/FastDeploy
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3145 导致开启SOT后报错:
排查后发现,是自定义算子 append_atten 的传参问题
运行动态图是没问题的,说明PYBIND部分
custom_ops/gpu_ops/cpp_extensions.cc的函数定义/声明是没问题的FastDeploy/custom_ops/gpu_ops/cpp_extensions.cc
Lines 82 to 84 in f516421
rms_norm_eps这个 float 值传入了compute_dtype这个 string 的位置来看自定义算子的定义/声明部分:
FastDeploy/custom_ops/gpu_ops/append_attention.cu
Lines 747 to 762 in f516421
这里的参数顺序与
cpp_extensions.cc中的顺序不同导致参数类型报错,本pr修改参数顺序与 cpp_extensions.cc 的对齐cc @zyfncg @SigureMo