Skip to content

[Accuracy diff No.26-27] Fix accuracy diff for paddle.linalg.(eigvals, eigvalsh) API - #429

Merged
cangtianhuang merged 2 commits into
PFCCLab:mainfrom
ooooo-create:eigvals_eigvalsh
Aug 8, 2025
Merged

cangtianhuang merged 2 commits into
PFCCLab:mainfrom
ooooo-create:eigvals_eigvalsh

Conversation

@ooooo-create

@ooooo-create ooooo-create commented Jul 24, 2025 •

Copy link
Copy Markdown
Contributor

eigvals 返回的是未排序的特征值,具有随机性,ci_ce 中的配置都存在于 random_calculation.txt 中,所以删除 report 中内容
图片

eigvalsh 在计算反向时,同 eigh #276 一样会使用特征向量,特征向量不唯一,同步设置 forward。生成 numpy 数据同 eigh
图片

@paddle-bot

paddle-bot Bot commented Jul 24, 2025

Copy link
Copy Markdown

Thanks for your contribution!

paddle.linalg.eigvals(x=Tensor([4, 4],"float64"), )
paddle.linalg.eigvalsh(Tensor([0, 5, 5],"float32"), )
paddle.linalg.eigvalsh(Tensor([2, 5, 5],"complex64"), )
paddle.linalg.eigvalsh(Tensor([2, 5, 5],"float32"), )

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle.linalg.eigvalsh 是否也需要删除?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改完不报错的都要删嘛,eigvalsh 改成 forword only 就可以跑过了

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

意思是 paddle.linalg.eigvalsh 仅有反向是随机的吗?

@ooooo-create ooooo-create Jul 27, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的是的,api 前向只输出特征值,不会输出特征向量,算子前向第二个输出是随机,和 eigh 一样

@cangtianhuang cangtianhuang self-assigned this Jul 27, 2025

@cangtianhuang cangtianhuang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cangtianhuang
cangtianhuang merged commit 33cb474 into PFCCLab:main Aug 8, 2025
@ooooo-create
ooooo-create deleted the eigvals_eigvalsh branch September 29, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants