Skip to content

[Accuracy diff No.8] Fix accuracy diff for bitwise_right_shift API - #194

Merged
wanghuancoder merged 7 commits into
PFCCLab:mainfrom
ooooo-create:fix
May 29, 2025
Merged

wanghuancoder merged 7 commits into
PFCCLab:mainfrom
ooooo-create:fix

Conversation

@ooooo-create

@ooooo-create ooooo-create commented May 27, 2025 •

Copy link
Copy Markdown
Contributor

处理 is_arithmetic 为 False 时的逻辑右移,暂时是站在 torch 结果对齐的角度直接复用了 __rshift__Rule

@paddle-bot

paddle-bot Bot commented May 27, 2025

Copy link
Copy Markdown

Thanks for your contribution!

@ooooo-create ooooo-create changed the title fix [Accuracy diff No.8] Fix accuracy diff for bitwise_right_shift API May 27, 2025
Comment thread tester/paddle_to_torch/mapping.json Resolved
Comment thread tester/paddle_to_torch/mapping.json Resolved
Comment thread tester/paddle_to_torch/mapping.json Resolved
@cangtianhuang

Copy link
Copy Markdown
Collaborator

@Cutelemon6 请 check 一下这部分修改

@Cutelemon6 Cutelemon6 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同学你好!为这三个 api 确定完 rule 映射后需要使用 engine v1 / v2 对 5_accuracy 目录下的对应 api 配置进行精度测试 --accuracy=True,参考 README 3. 使用介绍,pending_* 文件中的可以不测,保证 accuracy_5.txt 中的配置通过,通过后放一下截图吧💕

image

Comment thread tester/paddle_to_torch/mapping.json Resolved
Comment thread tester/paddle_to_torch/mapping.json Resolved
Comment thread tester/paddle_to_torch/mapping.json Resolved
@ooooo-create

Copy link
Copy Markdown
Contributor Author

通过后放一下截图吧💕

all bitwise_right_shift in /5_accuracy/accuracy_5.txt and 5_accuracy/pending_accuracy_1.txt has passed
图片

@Cutelemon6 Cutelemon6 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder
wanghuancoder merged commit db9f391 into PFCCLab:main May 29, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jun 10, 2025
@ooooo-create
ooooo-create deleted the fix branch September 29, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants