fix: handle prompts starting with dashes#99
Closed
c-h- wants to merge 1 commit into
Closed
Conversation
c-h-
force-pushed
the
fix/dash-prompt-crash
branch
from
835bc7d to
269ea67
Compare
Insert -- (end-of-options separator) before the prompt positional argument in codex, opencode, and pi-rust adapters. This prevents prompts starting with --- (e.g. YAML frontmatter) from being misinterpreted as CLI options by the downstream arg parser. Fixes #91 Co-Authored-By: Charlie Hulcher <charlie@kindo.ai>
c-h-
force-pushed
the
fix/dash-prompt-crash
branch
from
269ea67 to
8653477
Compare
Collaborator
Author
|
Closing this PR — the branch diverged from main during the refactor and inadvertently removes the The underlying bug (prompts starting with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--(end-of-options separator) before prompt positional arguments in codex, opencode, and pi-rust adapters---(e.g. YAML frontmatter from spec files) from being misinterpreted as CLI options by downstream arg parsersFixes #91
Test plan
--separator is present before prompt in codex, opencode, and pi-rust spawn args--separator