Week 14

IR/.clang-tidy

@@ -0,0 +1,8 @@
+---
+Checks: 'clang-diagnostic-*,-*,misc-*,performance-*,clang-analyzer-*,readability-function-size,readability-identifier-naming,readability-redundant-*,readability-mis*,readability-string-compare,readability-non-const-parameter,-clang-analyzer-security*,cppcoreguidelines-avoid-non-const-global-variables,-misc-no-recursion,bugprone-assignment-in-if-condition,bugprone-infinite-loop,bugprone-integer-division,bugprone-suspicious-string-compare,llvm-header-guard,google-global-names-in-headers,cppcoreguidelines-no-malloc,bugprone-use-after-move'
+WarningsAsErrors: '*,-misc-non-private-member-variables-in-classes'
+CheckOptions:
+  - key:             readability-function-size.LineThreshold
+    value:           '300'
+...
+

IR/CMakeLists.txt

@@ -1,34 +1,21 @@
 cmake_minimum_required(VERSION 3.20)
 project(bpf_ir)
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -O3")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror -Wstrict-prototypes -O3")
 
 add_executable(
     read
     read.c
     bpf_ir.c
     array.c
     ir_helper.c
+    ir_value.c
     ir_bb.c
     ir_insn.c
     passes/phi_pass.c
-    passes/reachable_bb.c
     passes/add_counter_pass.c
     passes/add_constraint_pass.c
     passes/cut_bb_pass.c
-    passes/end_bb.c
-    aux/live_variable.c
     aux/prog_check.c
-    aux/eliminate_ssa.c
-    aux/conflict_analysis.c
-    aux/graph_coloring.c
-    aux/explicit_reg.c
-    aux/coaleasing.c
-    aux/spill.c
-    aux/translate.c
-    aux/stack_alloc.c
-    aux/normalize.c
-    aux/fix_bb_succ.c
-    aux/relocate.c
     ir_code_gen.c
 )
 

IR/Makefile

@@ -0,0 +1,13 @@
+build:
+	cmake --build build
+
+run: build
+	build/read tests/${NAME}.o
+
+kernel: build
+	./scripts/gen_kernel.sh
+
+format:
+	./scripts/format.sh
+
+.PHONY: build run format

IR/Readme.md

@@ -12,6 +12,8 @@ One opinion, one benefit of designing the raw constraint from is that our runtim
 
 - [x] Register spilling
 - [x] Caller-saved/callee-saved register
+- [ ] Fix: stack offset should be changed before CG
+- [ ] VR type & Constant type (inference)
 - [ ] Translation
 
 # TODO

IR/array.c

@@ -1,95 +1,105 @@
-#include "array.h"
-#include <stdlib.h>
-#include <string.h>
+#include <linux/bpf_ir.h>
 
-void *__malloc(size_t size) {
-    void *data = malloc(size);
-    memset(data, 0, size);
-    return data;
+void bpf_ir_array_init(struct array *res, size_t size)
+{
+	res->data = NULL;
+	res->max_elem = 0;
+	res->elem_size = size;
+	res->num_elem = 0;
 }
 
-void __free(void *ptr) {
-    free(ptr);
+struct array bpf_ir_array_null(void)
+{
+	struct array res;
+	res.data = NULL;
+	res.max_elem = 0;
+	res.elem_size = 0;
+	res.num_elem = 0;
+	return res;
 }
 
-struct array array_init(size_t size) {
-    struct array res;
-    res.data      = __malloc(size * 4);
-    res.max_elem  = 4;
-    res.elem_size = size;
-    res.num_elem  = 0;
-    return res;
+int bpf_ir_array_push(struct array *arr, void *data)
+{
+	if (arr->data == NULL) {
+		SAFE_MALLOC(arr->data, arr->elem_size * 2)
+		arr->max_elem = 2;
+	}
+	if (arr->num_elem >= arr->max_elem) {
+		// Reallocate
+		void *new_data = NULL;
+		SAFE_MALLOC(new_data, arr->max_elem * 2 * arr->elem_size);
+		memcpy(new_data, arr->data, arr->num_elem * arr->elem_size);
+		free_proto(arr->data);
+		arr->data = new_data;
+		arr->max_elem *= 2;
+	}
+	// Push back
+	memcpy((char *)(arr->data) + arr->elem_size * arr->num_elem, data,
+	       arr->elem_size);
+	arr->num_elem++;
+	return 0;
 }
 
-struct array array_null() {
-    struct array res;
-    res.data      = NULL;
-    res.max_elem  = 0;
-    res.elem_size = 0;
-    res.num_elem  = 0;
-    return res;
+int bpf_ir_array_push_unique(struct array *arr, void *data)
+{
+	for (size_t i = 0; i < arr->num_elem; ++i) {
+		if (memcmp((char *)(arr->data) + arr->elem_size * i, data,
+			   arr->elem_size) == 0) {
+			return 0;
+		}
+	}
+	return bpf_ir_array_push(arr, data);
 }
 
-void array_push(struct array *arr, void *data) {
-    if (arr->num_elem >= arr->max_elem) {
-        // Reallocate
-        void *new_data = __malloc(arr->max_elem * 2 * arr->elem_size);
-        memcpy(new_data, arr->data, arr->num_elem * arr->elem_size);
-        __free(arr->data);
-        arr->data = new_data;
-        arr->max_elem *= 2;
-    }
-    // Push back
-    memcpy((char *)(arr->data) + arr->elem_size * arr->num_elem, data, arr->elem_size);
-    arr->num_elem++;
+void bpf_ir_array_erase(struct array *arr, size_t idx)
+{
+	if (idx >= arr->num_elem) {
+		return;
+	}
+	// Shift elements
+	for (size_t i = idx; i < arr->num_elem - 1; ++i) {
+		memcpy((char *)(arr->data) + arr->elem_size * i,
+		       (char *)(arr->data) + arr->elem_size * (i + 1),
+		       arr->elem_size);
+	}
+	arr->num_elem--;
 }
 
-void array_push_unique(struct array *arr, void *data) {
-    for (size_t i = 0; i < arr->num_elem; ++i) {
-        if (memcmp((char *)(arr->data) + arr->elem_size * i, data, arr->elem_size) == 0) {
-            return;
-        }
-    }
-    array_push(arr, data);
+int bpf_ir_array_clear(struct array *arr)
+{
+	free_proto(arr->data);
+	SAFE_MALLOC(arr->data, arr->elem_size * 4);
+	arr->max_elem = 4;
+	arr->num_elem = 0;
+	return 0;
 }
 
-void array_erase(struct array *arr, size_t idx) {
-    if (idx >= arr->num_elem) {
-        return;
-    }
-    // Shift elements
-    for (size_t i = idx; i < arr->num_elem - 1; ++i) {
-        memcpy((char *)(arr->data) + arr->elem_size * i,
-               (char *)(arr->data) + arr->elem_size * (i + 1), arr->elem_size);
-    }
-    arr->num_elem--;
+int bpf_ir_array_clone(struct array *res, struct array *arr)
+{
+	res->num_elem = arr->num_elem;
+	res->max_elem = arr->max_elem;
+	res->elem_size = arr->elem_size;
+	if (arr->num_elem == 0) {
+		res->data = NULL;
+		return 0;
+	}
+	SAFE_MALLOC(res->data, arr->max_elem * arr->elem_size);
+	memcpy(res->data, arr->data, arr->num_elem * arr->elem_size);
+	return 0;
 }
 
-void array_clear(struct array *arr) {
-    __free(arr->data);
-    arr->data     = __malloc(arr->elem_size * 4);
-    arr->max_elem = 4;
-    arr->num_elem = 0;
+void bpf_ir_array_free(struct array *arr)
+{
+	if (arr->data) {
+		free_proto(arr->data);
+	}
+	*arr = bpf_ir_array_null();
 }
 
-struct array array_clone(struct array *arr) {
-    struct array res;
-    res.num_elem  = arr->num_elem;
-    res.max_elem  = arr->max_elem;
-    res.elem_size = arr->elem_size;
-    res.data      = __malloc(arr->max_elem * arr->elem_size);
-    memcpy(res.data, arr->data, arr->num_elem * arr->elem_size);
-    return res;
-}
-
-void array_free(struct array *arr) {
-    __free(arr->data);
-    *arr = array_null();
-}
-
-void *array_get_void(struct array *arr, size_t idx) {
-    if (idx >= arr->num_elem) {
-        return NULL;
-    }
-    return (char *)(arr->data) + arr->elem_size * idx;
+void *bpf_ir_array_get_void(struct array *arr, size_t idx)
+{
+	if (idx >= arr->num_elem) {
+		return NULL;
+	}
+	return (char *)(arr->data) + arr->elem_size * idx;
 }