Skip to content

Add artisanal production switching - #605

Merged
wvpm merged 1 commit into
masterfrom
artisanal_production_switching
Nov 3, 2025
Merged

Add artisanal production switching#605
wvpm merged 1 commit into
masterfrom
artisanal_production_switching

Conversation

@wvpm

@wvpm wvpm commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Artisans now decide what to produce based on expected costs and revenue.
This replaces ArtisanalProducerFactoryPattern.

There are TODO's left for follow up PRs:

Ideally the artisan uses his old production type one last time and sells the produce but buys the inputs for the new production type. This significantly complicates the code and is best left for yet another follow up.

@wvpm wvpm added enhancement Issue that describes an improvement to the project topic:economy Issue that relates to international, national, state, province, and population economic behavior labels Oct 30, 2025
@wvpm
wvpm force-pushed the artisanal_production_switching branch from 5707c63 to 20f413a Compare October 30, 2025 13:07
@wvpm
wvpm force-pushed the artisanal_production_switching branch 3 times, most recently from d5d80d0 to 4975bb7 Compare October 30, 2025 14:26
@wvpm wvpm changed the title Artisans switch production Add artisanal production switching Oct 30, 2025
@wvpm
wvpm force-pushed the artisanal_production_switching branch from 4975bb7 to 460aa25 Compare October 30, 2025 14:39
@wvpm
wvpm marked this pull request as ready for review October 30, 2025 14:42
@wvpm wvpm mentioned this pull request Oct 30, 2025
7 tasks
@wvpm wvpm linked an issue Oct 30, 2025 that may be closed by this pull request
7 tasks
Comment thread src/openvic-simulation/economy/production/ArtisanalProducer.cpp Outdated
Comment thread src/openvic-simulation/economy/production/ArtisanalProducer.cpp Outdated
@wvpm
wvpm force-pushed the artisanal_production_switching branch from 460aa25 to bf7e237 Compare November 2, 2025 12:26
@wvpm wvpm mentioned this pull request Nov 2, 2025
@wvpm
wvpm force-pushed the artisanal_production_switching branch from bf7e237 to a12105b Compare November 3, 2025 10:29
Comment thread src/openvic-simulation/map/State.cpp Outdated
@wvpm
wvpm force-pushed the artisanal_production_switching branch from a12105b to 2192c04 Compare November 3, 2025 10:51
Comment thread src/openvic-simulation/economy/production/ProductionType.cpp
@wvpm
wvpm force-pushed the artisanal_production_switching branch from 2192c04 to 4c38346 Compare November 3, 2025 10:53
@wvpm
wvpm enabled auto-merge November 3, 2025 11:10
@wvpm
wvpm merged commit 6196003 into master Nov 3, 2025
16 checks passed
@Spartan322
Spartan322 deleted the artisanal_production_switching branch November 3, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue that describes an improvement to the project topic:economy Issue that relates to international, national, state, province, and population economic behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add artisanal production switching

3 participants