Skip to content

Load all mod descriptors and check dependencies - #470

Merged
wvpm merged 1 commit into
masterfrom
load-mod-descriptors
Aug 3, 2025
Merged

Load all mod descriptors and check dependencies#470
wvpm merged 1 commit into
masterfrom
load-mod-descriptors

Conversation

@BrickPi

@BrickPi BrickPi commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

A couple of improvements to mod loading in preparation for main repo ModMenu work.

  • Moves generic modloading logic from headless simulation to GameManager
  • Loads all mod descriptors present on disk (so that we can present them to the user in an in-game mod menu)
  • Loads selected mods + dependencies, with improved error handling and (simple) cycle prevention.
  • Allows users to specify full name or shorthand mod name when loading mods on command line ("HPM" and "Historical Project Mod 0.4.6" are both valid, for instance)

@BrickPi BrickPi added enhancement Issue that describes an improvement to the project topic:core Issue that applies to core functions, fundamental to the rest of the module labels Jun 24, 2025
Spartan322
Spartan322 reviewed Jun 24, 2025
View reviewed changes
Comment thread src/headless/main.cpp Outdated
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from 3740914 to 606edda Compare June 24, 2025 21:49
Spartan322
Spartan322 reviewed Jun 25, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
Spartan322
Spartan322 reviewed Jun 25, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.hpp Outdated
Spartan322
Spartan322 reviewed Jun 25, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.hpp Outdated
Spartan322
Spartan322 reviewed Jun 25, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
Spartan322
Spartan322 reviewed Jun 25, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
Spartan322
Spartan322 reviewed Jun 25, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
Spartan322
Spartan322 reviewed Jun 25, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from 606edda to 9586a84 Compare June 25, 2025 14:12
wvpm
wvpm reviewed Jun 29, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp
wvpm
wvpm reviewed Jun 29, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.hpp
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch 2 times, most recently from a55d5b1 to 7f50a20 Compare July 6, 2025 13:19
Spartan322
Spartan322 reviewed Jul 6, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.hpp Outdated
Spartan322
Spartan322 reviewed Jul 6, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.hpp Outdated
Spartan322
Spartan322 reviewed Jul 6, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch 2 times, most recently from 0941b0e to d9a3105 Compare July 6, 2025 16:24
wvpm
wvpm reviewed Jul 6, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp
wvpm
wvpm reviewed Jul 6, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from d9a3105 to bbfc74d Compare July 7, 2025 11:34
Spartan322
Spartan322 reviewed Jul 7, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from bbfc74d to 7c23bd2 Compare July 7, 2025 16:47
Spartan322
Spartan322 previously approved these changes Jul 7, 2025
View reviewed changes
@Spartan322
Spartan322 dismissed their stale review July 7, 2025 17:10

I get six errors on running it.

Spartan322
Spartan322 reviewed Jul 7, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/Dataloader.cpp Outdated
Spartan322
Spartan322 reviewed Jul 7, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
Spartan322
Spartan322 reviewed Jul 8, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/Dataloader.cpp Outdated
Spartan322
Spartan322 reviewed Jul 8, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/Dataloader.cpp Outdated
Spartan322
Spartan322 reviewed Jul 8, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
@BrickPi BrickPi mentioned this pull request Jul 8, 2025
Open
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from 3768b5e to 356c82c Compare July 14, 2025 14:56
@BrickPi BrickPi mentioned this pull request Jul 14, 2025
Merged
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from 356c82c to 56e12aa Compare July 14, 2025 15:27
wvpm
wvpm reviewed Jul 14, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
wvpm
wvpm reviewed Jul 14, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
wvpm
wvpm reviewed Jul 14, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/Dataloader.cpp Outdated
wvpm
wvpm reviewed Jul 14, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.hpp Outdated
wvpm
wvpm reviewed Jul 14, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
wvpm
wvpm previously approved these changes Jul 14, 2025
View reviewed changes
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from 56e12aa to 8fafde8 Compare July 14, 2025 21:17
Spartan322
Spartan322 reviewed Jul 15, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
@BrickPi
BrickPi force-pushed the load-mod-descriptors branch from 8fafde8 to 39ef1a5 Compare July 15, 2025 09:42
wvpm
wvpm reviewed Jul 15, 2025
View reviewed changes
Comment thread src/openvic-simulation/dataloader/ModManager.cpp Outdated
wvpm
wvpm previously approved these changes Jul 15, 2025
View reviewed changes
@wvpm
wvpm force-pushed the load-mod-descriptors branch from 39ef1a5 to 7621ade Compare July 31, 2025 07:43
wvpm
wvpm reviewed Jul 31, 2025
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
@wvpm
wvpm force-pushed the load-mod-descriptors branch 2 times, most recently from a47befc to aca26a7 Compare July 31, 2025 07:54
@wvpm
wvpm force-pushed the load-mod-descriptors branch from aca26a7 to 00fa204 Compare July 31, 2025 07:56
@wvpm wvpm added this to the 0.9.0 milestone Aug 3, 2025
@wvpm
wvpm merged commit c5dfb95 into master Aug 3, 2025
16 checks passed
@wvpm
wvpm deleted the load-mod-descriptors branch August 3, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Spartan322 Spartan322 Spartan322 left review comments
@wvpm wvpm wvpm approved these changes

Assignees

No one assigned

Labels

enhancement Issue that describes an improvement to the project topic:core Issue that applies to core functions, fundamental to the rest of the module

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BrickPi @Spartan322 @wvpm