Skip to content

upgrade to node20#46

Merged
mpeyper merged 2 commits into
OpenSourceRaidGuild:mainfrom
vctqs1:main
Dec 18, 2023
Merged

upgrade to node20#46
mpeyper merged 2 commits into
OpenSourceRaidGuild:mainfrom
vctqs1:main

Conversation

@vctqs1

@vctqs1 vctqs1 commented Dec 16, 2023

Copy link
Copy Markdown
Contributor

What: Upgrade to node20

Why:

npm does not support Node.js v15.14.0. You should probably upgrade to a newer version of node 

The warning: https://github.com/OpenSourceRaidGuild/babel-vite/actions/runs/7214403907/job/19656427159#step:5:434

After upgrade to node20: No warning anymore https://github.com/vctqs1/babel-vite/actions/runs/7231706878/job/19705165603#step:5:28

https://github.com/OpenSourceRaidGuild/babel-vite/actions/runs/7214403907/job/19656533364#step:7:168)

How: Install node20 in CI

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@vctqs1

vctqs1 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

@JacobMGEvans @mpeyper Could you two help to review this PR

@codecov

codecov Bot commented Dec 18, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8dbeb9) 100.00% compared to head (b5c288b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          130       130           
  Branches        49        49           
=========================================
  Hits           130       130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpeyper mpeyper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpeyper
mpeyper merged commit 010d7e3 into OpenSourceRaidGuild:main Dec 18, 2023
@mpeyper

mpeyper commented Dec 18, 2023

Copy link
Copy Markdown
Member

Still failing to release 😞

@vctqs1

vctqs1 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

seem another error


npm ERR! code ETARGET
npm ERR! notarget No matching version found for babel-plugin-transform-vite-meta-glob@1.1.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

the latest version is 1.0.3 https://www.npmjs.com/package/babel-plugin-transform-vite-meta-glob
image

@vctqs1

vctqs1 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

Seem The problem arises because the release for babel-preset-vite is attempting to use version 1.1.0 of babel-plugin-transform-vite-meta-glob, but it seems that version hasn't been released yet due to a change in the release order.

https://github.com/OpenSourceRaidGuild/babel-vite/actions/runs/7244477736/job/19732886850#step:7:97

The correct sequence should have been releasing babel-plugin-transform-vite-meta-glob version 1.1.0 first, followed by the release of babel-preset-vite version 1.1.1. However, it seems that the order got mixed up, causing babel-preset-vite to look for a version of babel-plugin-transform-vite-meta-glob that hasn't been released yet.

@mpeyper The release order is randomly or specific order?

@vctqs1

vctqs1 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

@mpeyper I created another PR #47 to set --sequential-init avoid hypothetical concurrent initialization collisions.
(https://www.npmjs.com/package/@qiwi/multi-semantic-release)

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.1.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.1.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants