Repository navigation
fix(video_compose): resolve and stage edit_decisions.audio.music for Remotion renders - #938
Open
gauravchahal20 wants to merge 1 commit into
Open
gauravchahal20 wants to merge 1 commit into
gauravchahal20 wants to merge 1 commit into
Conversation
…Remotion renders Resolves edit_decisions.audio.music and legacy edit_decisions.music against asset_manifest before rendering. Adapts snake_case fade fields to the camelCase properties expected by Remotion compositions (CinematicRenderer and Explainer). Ensures explicit but missing asset_ids fail loudly rather than silently rendering silence. Fixes OpenMontageInc#937
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves
edit_decisions.audio.musicand legacyedit_decisions.musicagainstasset_manifestbefore rendering inVideoCompose. Adapts snake_case fade fields (fade_in_seconds,fade_out_seconds) into the camelCase properties (fadeInSeconds,fadeOutSeconds) expected by Remotion compositions (CinematicRendererandExplainer), and ensures audio tracks are properly staged into Remotion's public directory. Also fails loudly with a clear error if an explicitasset_idcannot be resolved againstasset_manifestrather than silently rendering silence and failing downstream review.Related issue
Closes #937
Changes
VideoCompose._resolve_music: resolvesedit_decisions.audio.musicor top-leveledit_decisions.musicasset_idto file paths fromasset_manifest.fadeInSeconds,fadeOutSeconds) to satisfy both Remotion'sCinematicRendererProps/Explainerand the underlying artifact schema.VideoCompose._renderto pass resolved music intoremotion_inputs,_render_via_hyperframes,_render_via_ffmpeg, and_pre_compose_validation.VideoCompose._remotion_renderto synchronizeprops.music(forCinematicRenderer) andprops.audio.music(forExplainer) so both composition shapes receive the resolved and staged music configuration.VideoCompose._composeFFmpeg fallback to pick up music ifaudio_pathwas not explicitly provided.tests/tools/test_cinematic_remotion_adapter.pyverifying canonical & legacy music resolution, missing asset ID handling, and end-to-end Remotion staging into props.Testing
Ran the full compose test suite:
pytest tests/tools/test_cinematic_remotion_adapter.py(13 passed)pytest tests/tools/test_video_compose_cache_identity.py(35 passed)pytest tests/tools/test_video_compose_chart_palette.py(4 passed)pytest tests/tools/test_video_compose_profile_aspect.py(2 passed)pytest tests/tools/test_video_compose_vertical.py(3 passed)All 57 tests passed.
Checklist
make test-contracts/make test) where applicable.