Repository navigation
fix(video_compose): pass per-cut tone and filter to CinematicRenderer - #920
Open
executorrr86 wants to merge 1 commit into
Open
executorrr86 wants to merge 1 commit into
executorrr86 wants to merge 1 commit into
Conversation
CinematicRenderer already reads tone and filter on each video scene, but the cut adapter dropped them, so every clip got the default filter and cold wash and there was no way to turn them off from edit_decisions. The adapter now copies them, the schema accepts them on cuts, and tone "none" removes the wash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CinematicRendererreadstoneandfilteron each video scene, and its fixtures use them, butvideo_compose's cut adapter (_cuts_to_cinematic_scenes) drops both. Every clip gets the default CSS filter and cold colour wash, andedit_decisionshas no way to change or turn them off. On footage that is already dark or graded, the picture comes out much darker than the source.This passes both fields through, accepts them on cuts in the schema, and adds
tone: "none"to remove the wash.Related issue
None. Refs #41, whose adapter copied these fields but was never merged, and #459, which adds a single piece-wide
metadata.cinematic_tone, withoutnoneorfilter.Changes
video_compose.py: the cut adapter copiestoneandfilterto the video scene when the cut sets them. Cuts without them produce the same scenes as before.CinematicRenderer.tsx/cinematic/types.ts: new tonenone(no wash).edit_decisions.schema.json:tone(enumcold,steel,void,neutral,none) andfilter(string) on cuts. Without them a cut withtonefails the checkpoint ("Additional properties are not allowed"). The descriptions say title cuts ignore them.skills/pipelines/cinematic/compose-director.md: one paragraph on the default grade and how to turn it off.Measured
Frame 30 of a flat grey clip (value 128), centre of the frame, through the adapter and
remotion still:tone: "none"filter: "none"tone: "neutral",filter: "none"tone: "none",filter: "none"On
main, every row comes out as the default (84): the scene reaches the renderer with notoneorfilter. The vignette is not affected: corners stay darker even with both set tonone.Testing
npx tsc --noEmit: clean.pytest tests: 2924 passed, 17 skipped.test_cinematic_remotion_adapter.py: the adapter copies both fields and leaves cuts without them unchanged.test_phase0_contracts.py: the schema accepts a valid grade and rejectstone: "warm"and a non-stringfilter.test_cinematic_cut_grade_render.pyrenders real frames: the default still darkens,tone+filternonekeeps 128, andtone: "none"alone sits between them. It is skipped when Remotion is not installed, so it does not run in the current CI job.nonecase in the TSX (2 failures), the adapter lines (3) and the schema fields (1).Checklist
make test-contracts/make test) where applicable.🤖 Generated with Claude Code