Repository navigation
Conversation
`make setup` installs piper into .venv/bin, so unless the venv was activated the tool reported UNAVAILABLE while installed. Look next to the running interpreter as a fallback, and call that binary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make setupinstallspiper-ttsinto.venv/bin.piper_tts.get_status()only checkedshutil.which("piper"), so unless the venv was activated in the shell, the tool reported UNAVAILABLE while installed (e.g. when an agent runs.venv/bin/python -c ...without activating). It now also looks next to the running interpreter, and_generatecalls the binary it found.Related issue
None — found while running the preflight from a non-activated venv.
Changes
tools/audio/piper_tts.py:_piper_binary()— PATH first, thenPath(sys.executable).parent / "piper"; used byget_status()and_generate().tests/tools/test_piper_venv_binary.py: found in the venv when not on PATH; UNAVAILABLE when absent everywhere.Testing
mainand passes with the fix.pytest tests: 1831 passed, 11 skipped, 3 xfailed (macOS, Python 3.12).Checklist
make test-contracts/make test) where applicable.🤖 Generated with Claude Code