Fuselage layout enhancement and modification - #1205
Open
xjjiang wants to merge 63 commits into
Open
Conversation
…ECONOMY. Fixed a bug DetailedCabinLayout. Added business class to DetailedCabinLayout
…ECONOMY. added Aircraft.Fuselage.SEAT_WIDTH_BUSINESS and Aircraft.Fuselage.SEAT_WIDTH_FIRST. removed LEAPS1.
…ge.SEAT_WIDTH_FIRST
xjjiang
marked this pull request as ready for review
July 1, 2026 19:00
xjjiang
changed the title
jkirk5
reviewed
Jul 10, 2026
jkirk5
left a comment
jkirk5
left a comment
Contributor
There was a problem hiding this comment.
Some additional comments, full review WIP
cmbenne3
requested changes
Jul 16, 2026
cmbenne3
left a comment
cmbenne3
left a comment
Contributor
There was a problem hiding this comment.
I think we still need a couple of changes to preprocessors.
Contributor
Author
I accepted your suggested changes. However, I have to set |
cmbenne3
requested changes
Jul 20, 2026
cmbenne3
requested changes
Jul 23, 2026
cmbenne3
left a comment
cmbenne3
left a comment
Contributor
There was a problem hiding this comment.
Hopefully the very final change before we merge this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For FLOPS based geometry, business seats are added to transporter aircraft. For GASP based geometry, business class seats are added to BWB aircraft. In both cases, users can set:
For FLOPS based models, there will be differences of fuselage layout if business class seats are included for transporter aircraft because FLOPS does not consider business seats in its layout algorithm. This message is added to the top of output .csv file.
GASP based geometry does not have a detailed layout for transporter aircraft. We do not add this feature in this PR.
Related Issues
Backwards incompatibilities
None
New Dependencies
None