Fix how variables are set in site startup file#22681
Merged
Merged
Conversation
- Man-sed-program should be Man-sed-command - Use setopt instead of set-variable to take into account that they are variables declared with defcustom
nealsid
force-pushed
the
emacs-set-variable-fix
branch
from
8dc9615 to
d584e6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Man-sed-programshould beMan-sed-command(unfortunately in my testing of the previous commit, my.emacssetMan-sed-commandso I didn't catch thatsite-startup.elwas setting the wrong variable. I tested this change withemacs -q)setoptinstead ofset-variableto take into account that they are variables declared with defcustom - this did not cause any breakage but is considered better style becausesetoptruns setters for custom variables when they are set.