fix(docker): Docker 배포 설정 오류 수정 by qowlgur121 · Pull Request #49 · OpenContextAI/open-context

qowlgur121 · 2025-12-15T10:10:25Z

요약

Issue #48에서 보고된 Docker 환경 설정 오류를 수정했습니다.

변경 사항

1. Dockerfile 베이스 이미지 변경

openjdk:21-slim (존재하지 않음) -> eclipse-temurin:21-jre-jammy

2. application-docker.yml 수정

항목	변경 전	변경 후
DB URL	localhost:5432	postgres:5432
DB 계정	postgres/3482	user/password
RAG URL	localhost:8001	open-context-rag:8001
ES URL	localhost:9200	elasticsearch:9200
Ollama URL	localhost:11434	ollama:11434
MinIO URL	localhost:9000	minio:9000
MinIO secret	minioadmin	minioadmin123!
spring.profiles.active	dev	제거

3. docker-compose.yml 수정

임베딩 모델을 bge-m3:latest로 통일 (PR Feature/rag/#37 #46 설명과 일치)

4. .gitignore 추가

.cursor/ (IDE)
.gradle-user-home/ (Gradle 캐시)
__pycache__/, *.pyc, *.pyo (Python 캐시)

테스트

Docker Compose로 전체 서비스 실행 확인
Core 서비스 health check 통과
RAG 서비스 health check 통과

Pull request overview

This PR fixes Docker deployment configuration errors (Issue #48) by updating base images, migrating to a Python FastAPI-based RAG service, and correcting environment configurations for container networking.

Replaces non-existent openjdk:21-slim with eclipse-temurin:21-jre-jammy
Implements new Python RAG service with FastAPI, replacing direct Elasticsearch/Ollama integration in Java
Updates service URLs from localhost to Docker service names (postgres, elasticsearch, ollama, minio)

Reviewed changes

Copilot reviewed 38 out of 63 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
core/Dockerfile	Updates base image to eclipse-temurin:21-jre-jammy
docker-compose.yml	Adds RAG service, updates model to bge-m3:latest, removes unstructured-api
core/src/main/resources/application-docker.yml	Configures service URLs for Docker networking, adds RAG service URL
core/src/main/resources/application.yml	Updates local dev config with RAG service URL
core/src/main/java/com/opencontext/controller/SourceController.java	Integrates RAG service via REST API
core/src/main/java/com/opencontext/service/FileStorageService.java	Adds presigned URL generation for MinIO
core/src/main/java/com/opencontext/config/SecurityConfig.java	Disables API key authentication (security risk)
rag/*	Complete Python FastAPI RAG service implementation
.gitignore	Adds .cursor/, .gradle-user-home/, pycache/
rag//pycache*/	Python cache files incorrectly committed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-15T10:26:58Z

+app.add_middleware(
+    CORSMiddleware,
+    allow_origins=["*"],  # In production, restrict to specific origins


The CORS middleware is configured to allow all origins ("*") with credentials enabled. This is a security risk in production as it allows any website to make authenticated requests to the API. Consider restricting allowed origins to specific domains or making this configurable via environment variables.

Copilot · 2025-12-15T10:26:58Z

    hibernate:
-      ddl-auto: validate
-    show-sql: true
+      ddl-auto: update


The ddl-auto setting has been changed from 'validate' to 'update' in the Docker configuration. This allows Hibernate to automatically modify the database schema, which can be dangerous in production as it may lead to unintended schema changes or data loss. Consider using 'validate' with proper Flyway migrations or making this environment-specific.

Suggested change

ddl-auto: update

ddl-auto: validate

Copilot · 2025-12-15T10:26:59Z

-  # Flyway Configuration (Docker)
+  # Flyway Configuration
  flyway:
    baseline-on-migrate: true


The Flyway configuration locations and validate-on-migrate settings have been removed. This removes important database migration validation and could lead to deployment issues if migrations are not properly tracked. These settings should be retained to ensure database schema consistency.

Suggested change

baseline-on-migrate: true

baseline-on-migrate: true

locations: classpath:db/migration

validate-on-migrate: true

Copilot · 2025-12-15T10:26:59Z

+    if settings.elasticsearch_url.startswith("https"):
+        client_params["verify_certs"] = settings.elasticsearch_verify_certs
+        if not settings.elasticsearch_verify_certs:
+            # Suppress SSL warnings in development
+            import urllib3
+            urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)


The elasticsearch_verify_certs configuration defaults to True but SSL warnings are disabled when set to False. This suppresses important security warnings in development. Consider logging a warning message instead of completely disabling urllib3 warnings, so other security issues aren't masked.

Copilot · 2025-12-15T10:26:59Z

+@app.exception_handler(Exception)
+async def general_exception_handler(request: Request, exc: Exception):
+    """Handle unexpected exceptions."""
+    logger.error(f"Unexpected error: {str(exc)}", exc_info=True)
+    return JSONResponse(
+        status_code=500,
+        content={"detail": "Internal server error"}
+    )


The error handler catches all exceptions and returns a generic "Internal server error" message without logging the full exception details for security. However, this makes debugging production issues difficult. Consider adding a request ID to the response and logging it with full exception details server-side for troubleshooting.

Copilot · 2025-12-15T10:27:02Z

+import logging
+
+from app.config.settings import settings
+from app.utils.exceptions import RagServiceException, rag_exception_handler


Import of 'rag_exception_handler' is not used.

Copilot · 2025-12-15T10:27:03Z

+Internal API called by core/ service after file upload.
+"""
+import logging
+from fastapi import APIRouter, HTTPException


Import of 'HTTPException' is not used.

Suggested change

from fastapi import APIRouter, HTTPException

from fastapi import APIRouter

Copilot · 2025-12-15T10:27:03Z

+from app.models.responses import ProcessResponse
+from app.services.parsing import DocumentParsingService
+from app.services.chunking import ChunkingService
+from app.services.embedding import EmbeddingService


Import of 'EmbeddingService' is not used.

Suggested change

from app.services.embedding import EmbeddingService

Copilot · 2025-12-15T10:27:03Z

+from app.services.parsing import DocumentParsingService
+from app.services.chunking import ChunkingService
+from app.services.embedding import EmbeddingService
+from app.services.indexing import IndexingService


Import of 'IndexingService' is not used.

Suggested change

from app.services.indexing import IndexingService

Copilot · 2025-12-15T10:27:04Z

+Provides accurate token counting for content retrieval with truncation support.
+"""
+import tiktoken
+from typing import Optional


Import of 'Optional' is not used.

Yoo-SH and others added 6 commits August 22, 2025 02:24

feat: Initial release - merge develop to main #36

f6ba43d

- Pull Request: develop → main - First stable version ready for production

refactro(#37): rag서비스 분리

9000ea2

- rag pipeline fastapi에서 처리 - langchain과 결합 - elasticsearch 데이터 저장 for(keyword, vector)

refactor(#37): 백엔드 rag 리팩토링

08279e2

- 백엔드에서는 rag 검색만 진행 - 키워드(파일원본,제목,본문)검색+백터검색 3/7 - unstructed io 관련설정 제거

build(#37): 도커 컴포즈 파일 업데이트

527c0a9

Merge branch 'main' into feature/rag/#37

5688122

Yoo-SH requested a review from Copilot December 15, 2025 10:18

Copilot started reviewing on behalf of Yoo-SH December 15, 2025 10:18 View session

Yoo-SH merged commit d082cb1 into develop Dec 15, 2025
5 checks passed

Copilot AI reviewed Dec 15, 2025

View reviewed changes

	from fastapi import APIRouter, HTTPException
	from fastapi import APIRouter

Uh oh!

Conversation

qowlgur121 commented Dec 15, 2025

요약

변경 사항

1. Dockerfile 베이스 이미지 변경

2. application-docker.yml 수정

3. docker-compose.yml 수정

4. .gitignore 추가

테스트

관련 이슈

Uh oh!

Yoo-SH commented Dec 15, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants