Skip to content

Add annotations to the operation - case permission validation - Fix 12219 15822#16259

Merged
borsch merged 5 commits into
OpenAPITools:masterfrom
rodrigoma3:fix_12219_15822
Aug 9, 2023
Merged

Add annotations to the operation - case permission validation - Fix 12219 15822#16259
borsch merged 5 commits into
OpenAPITools:masterfrom
rodrigoma3:fix_12219_15822

Conversation

@rodrigoma3

@rodrigoma3 rodrigoma3 commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Add annotations to the operation. There are 3 annotations for permission validation and they all have their advantages, and they need to be in operation to work, so it's open to add any annotation (identical to x-field-extra-annotation and x-class-extra-annotation).
fix #12219
fix #15822

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)

@rodrigoma3

Copy link
Copy Markdown
Contributor Author

@wing328 Could you approve this PR?

Comment thread modules/openapi-generator/src/test/resources/2_0/issue12219.yaml
@rodrigoma3 rodrigoma3 requested a review from borsch August 8, 2023 22:22
@borsch

borsch commented Aug 9, 2023

Copy link
Copy Markdown
Member

@rodrigoma3 please update samples and I'll merge this PR

@rodrigoma3

Copy link
Copy Markdown
Contributor Author

@rodrigoma3 please update samples and I'll merge this PR

done

@borsch borsch closed this Aug 9, 2023
@borsch borsch reopened this Aug 9, 2023
@borsch borsch merged commit d955ff6 into OpenAPITools:master Aug 9, 2023
@borsch borsch added this to the 7.0.0 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants