[BUG] [typescript-angular] Use a relative basePath

[bartbergmans]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

I am using the typescript-angular generator. In the api.service it generates a basePath using http://localhost when you use a relative path.

protected basePath = 'http://localhost';

openapi-generator version

5.3.1

OpenAPI declaration file content or url

servers:
  - url: '/api'

Steps to reproduce

Set the url in the openapi specification to a relative path, for example /api. When you run the typescript-angular generator now, it will generate the basePath in the api.service as http://localhost/api instead of /api

Related issues/PRs

#2731
#8576

Suggest a fix

Remove the prefixed http://localhost when a relative path is used.

[macjohnny]

Would you like to fix this?

[bartbergmans]

Any idea where I should look to fix this? I have looked at the code but couldn't find the localhost part anywhere.

[macjohnny]

here are some starting points:

openapi-generator/modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache

Line 62 in d1089d7

protected basePath = '{{{basePath}}}';

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptAngularClientCodegen.java

Line 36 in d1089d7

public class TypeScriptAngularClientCodegen extends AbstractTypeScriptClientCodegen {

[code1x1]

already fixed in #10056 waiting for PR merge. this is a general problem. the cli tool just adds a http://localhost if the address is relative because the path gets wrapped in URL class which adds localhost automaticlly if no host part exists added a check if url ist relativ just save as is