Repository navigation
Harden untrusted input remoteproc - #703
Merged
arnopo merged 2 commits intoSep 22, 2026
Merged
Conversation
arnopo
approved these changes
Sep 15, 2026
tnmysh
approved these changes
Sep 16, 2026
Collaborator
|
Hi @bentheredonethat |
The remote resource table controls the vring alignment, which is used for pointer rounding without validation. vring_init() rounds the used ring address with a ~(align - 1) mask, so a zero alignment leaves a NULL used ring that is dereferenced later. Reject a zero alignment before calculating the vring size and before storing the vring metadata taken from the resource table. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Assisted-by: Codex:GPT-5
Resource offsets from a copied firmware table are dereferenced without bounds checks when no I/O region is present. Handlers can then access memory beyond the table through a VDEV's flexible vring array. Reject a NULL table, validate offset-array arithmetic, and require every entry to remain inside the table before dispatch. Check fixed sizes, VDEV vrings and config data, and vendor lengths using overflow-safe subtraction. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Assisted-by: Codex:GPT-5
bentheredonethat
force-pushed
the
Harden-untrusted-input-remoteproc
branch
from
September 21, 2026 14:20
9e393a9 to
43a7a0d
Compare
Contributor
Author
|
@arnopo rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.