Skip to content

fix(ci): pin mcp additional_dependency in mypy pre-commit hook #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSv4 merged 1 commit into from
Sep 6, 2026
Merged

fix(ci): pin mcp additional_dependency in mypy pre-commit hook #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,11 @@ repos:
- spacy
- tokenizers>=0.21,<0.23
- posthog==7.12.0
- mcp>=1.0.0
# Ceiling matches requirements/base.txt's runtime pin. mcp>=1.0.0
# (no ceiling) let this hook resolve mcp 2.x, whose SDK renamed
# fields/methods that opencontractserver/mcp/server.py (1.x API)
# doesn't have -- turning main red with no commit touching mcp.
- mcp>=1.28.1,<2
- argon2-cffi==25.1.0
- cryptography==46.0.7
- pyjwt==2.12.1
Expand Down
1 change: 1 addition & 0 deletions changelog.d/pin-mcp-precommit-mypy-hook.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Pinned the `mcp` `additional_dependencies` entry in the mypy pre-commit hook (`.pre-commit-config.yaml`) to `>=1.28.1,<2`, matching the runtime pin in `requirements/base.txt`. The previous unbounded `mcp>=1.0.0` let the hook resolve `mcp` 2.x, whose SDK renamed/removed fields and methods (`Server.list_resources`, `uriTemplate`→`uri_template`, `inputSchema`→`input_schema`) that `opencontractserver/mcp/server.py` (written against the 1.x API) still uses — producing 48 unrelated mypy errors on every PR's `linter`/`backend-ci-gate` checks regardless of what the PR actually changed.
Loading