Open
Conversation
ragusa
reviewed
Feb 27, 2026
| } | ||
|
|
||
| size_t GetNumGhostDOFs(const UnknownManager& unknown_manager) const override; | ||
| std::uint64_t GetNumGhostDOFs(const UnknownManager& unknown_manager) const override; |
Contributor
There was a problem hiding this comment.
What will happen if a user, for whatever reason, does not compile with Petsc64? This line hardcodes that PetscInt is expected to be a uint64, right?
Collaborator
There was a problem hiding this comment.
cmake will fail to configure the project if PETSc isn't compiled with 64-bit integers. We specifically check for that and throw an error.
Collaborator
Author
There was a problem hiding this comment.
Yes. Currently, we stop if trying to build against PETSc with 32-bit indexing, see code.
If 32-bit indexing is desired, then we have much larger problems to fix... Things like sparsity patterns, parallel STL vector, etc...
Also, size_t is 64-bit integer on 64-bit architectures, so this particular change just unifies the used type...
framework/math/spatial_discretization/finite_volume/finite_volume.cc
Outdated
Show resolved
Hide resolved
wdhawkins
approved these changes
Mar 1, 2026
andrsd
force-pushed
the
issue/90-num-dofs
branch
2 times, most recently
from
2f0ea29 to
4e0ec62
Compare
andrsd
force-pushed
the
issue/90-num-dofs
branch
from
4e0ec62 to
803b800
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.