Fix loader indicator state#2985
Merged
Merged
Conversation
The flag controlling the loader needs to be reset when the layout component is connected. Otherwise it might appear as active and.
plamen-yordanov
previously approved these changes
Jun 1, 2026
svilenvelikov
dismissed
plamen-yordanov’s stale review
The base branch was changed.
boyan-tonchev
approved these changes
Jun 1, 2026
plamen-yordanov
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Resets the onto-layout loader indicator when the component connects so it doesn’t remain stuck in an “active” state due to missed/late lifecycle events.
Changes:
- Reset
loadingtofalseinconnectedCallback()to clear stale loader state on (re)connect.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix loader indicator state
Why
The flag controlling the loader needs to be reset when the layout component is connected. Otherwise it might appear as active and.
How
Testing
Screenshots
Checklist