Repository navigation
Conversation
JoeRobich
approved these changes
Oct 26, 2023
JoeRobich
left a comment
JoeRobich
left a comment
Member
There was a problem hiding this comment.
Thanks @ycholette! I think this change makes sense.
This was referenced Oct 7, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are showing warnings/errors in our UI and this would pop up every time a client disconnects (usually by the user). This error should not result in a critical message in the log IMO. What do you think?
Not 100% about the wording of the message to show in this case though.