sync: report identifying config context on success and failure - #64
Merged
Merged
Conversation
RepoResult/RepoEvent now carry the group name a repo belongs to, so two repos with the same name in different groups can be told apart in a run's report. printReport's FAIL line prints path and group the same way OK already does, and the live progress line prints the actual error text on failure instead of just the outcome. Identity validation errors (e.g. an invalid signing_method) are wrapped with repo/group/path so a typo can be traced back to its config entry without hand-bisecting the TOML. Both the human-readable and --json reports state the resolved config file path used for the run, and --json gains additive group/config fields. Closes #63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
syncfails partway through, the failure could not be traced back to the config entry that caused it, and neither report format confirmed which config file was even in play.RepoResult/RepoEventnow carry the group name a repo belongs to, so same-named repos in different groups are distinguishable in a run's results.FAILline now prints path and group, matching what theOKline already showed.signing_method) are now wrapped with repo name, path, and group, so they're traceable without hand-bisecting the TOML.--jsonoutput gains agroupfield per repo and a top-levelconfigfield — purely additive, no existing field renamed or removed.Test plan
gofmt -l .,go vet ./...,go test ./... -race -count=1 -vall passsigning_methodproducing a traceable error, the resolved config path appearing in both a successful and a failing report (for bothsyncandstatus), theFAILline's path/group content, and the progress line's error textCloses #63