Move to FluentAssertions 7.2.2 and pin below 8.x - #135
Merged
Conversation
The test project has been on FluentAssertions 4.19.2 for years. Every Dependabot attempt to move it has failed to build, because 6.x renamed BeCloseTo's tolerance parameter from int milliseconds to a TimeSpan and Dependabot cannot edit test code to keep up. FluentAssertions 8.0.0 moved to a paid commercial licence, so the version is expressed as the range [7.2.2,8.0.0). Note that a bare Version="7.2.2" would be a minimum rather than a pin, and would still allow a transitive reference to float onto 8.x. A matching Dependabot ignore rule stops 8.x being proposed again. It uses an explicit version range rather than version-update:semver-major, which would have blocked this upgrade too. Supersedes the Dependabot attempts in #133, #103 and #75. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
marked this pull request as ready for review
August 14, 2026 01:23
NickJosevski
enabled auto-merge (rebase)
August 14, 2026 01:23
zentron
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the Dependabot attempts in #133, #103 and #75.
The test project has been on FluentAssertions 4.19.2 for years. Every Dependabot attempt to move it has failed to build for the same reason: 6.x changed
BeCloseTo's tolerance parameter fromintmilliseconds to aTimeSpan, and Dependabot only edits the.csproj— it can never fix the three call sites, so those PRs can never go green on their own.That is the entire compatibility gap. With those three lines fixed, all 614 tests pass on 7.2.2.
Why 7.2.2 and not 8.10.0
FluentAssertions 8.0.0 moved to a paid commercial licence, so #133's jump to 8.10.0 is a procurement decision rather than a routine bump. 7.2.2 is the newest release under the old terms.
Why a range and not a version
Version="7.2.2"in NuGet means >= 7.2.2, not a pin — a transitive reference could still float onto 8.x.[7.2.2,8.0.0)allows 7.x patches and hard-blocks 8.0.0+. Verified inproject.assets.json.The matching Dependabot
ignorerule uses an explicit>=8.0.0range rather thanversion-update:semver-major, because the latter would have blocked this very upgrade while the project sat on 4.19.2.Notes
Octopus.Versioningneeds nothing —masteris already on 5.1.882, ahead of the 5.1.876 that closed PR Bump Octopus.Versioning from 5.1.827 to 5.1.876 in /source #104 proposed.